Skip to content

Conversation

@ReenigneArcher
Copy link
Member

Description

Just moving NSIS packaging in preparation for LizardByte/roadmap#76, which is probably needed for #3905 (or #3369)

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@sonarqubecloud
Copy link

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) May 26, 2025 20:26
@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 11.51%. Comparing base (883eff5) to head (4fd47e7).
⚠️ Report is 121 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3915   +/-   ##
=======================================
  Coverage   11.51%   11.51%           
=======================================
  Files          92       92           
  Lines       17499    17499           
  Branches     8152     8152           
=======================================
  Hits         2015     2015           
  Misses      12988    12988           
  Partials     2496     2496           
Flag Coverage Δ
Linux 11.14% <ø> (ø)
Windows 12.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@codecov
Copy link

codecov bot commented May 26, 2025

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher merged commit 356545f into master May 26, 2025
42 checks passed
@ReenigneArcher ReenigneArcher deleted the refactor/installer/windows/move-nsis-code branch May 26, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet