fix(windows): Add dynamic cursor fix (mousekeys) for KVM switches #4071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstokes22
force-pushed
the
fix/windows-dynamic-mousekeys
branch
3 times, most recently
from
b674e9f to
37fb41d
Compare
ReenigneArcher
force-pushed
the
fix/windows-dynamic-mousekeys
branch
from
37fb41d to
1b707b0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4071 +/- ##
==========================================
- Coverage 11.31% 11.31% -0.01%
==========================================
Files 92 92
Lines 17571 17573 +2
Branches 8239 8239
==========================================
Hits 1989 1989
- Misses 14901 14903 +2
Partials 681 681
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cgutman
requested changes
Jul 15, 2025
src/main.cpp
Outdated
| { | ||
| // Check if devices change | ||
| if (wParam == DBT_DEVNODES_CHANGED) { | ||
| platf::check_and_force_cursor_visibility(); |
There was a problem hiding this comment.
You should only enable this behavior if we're actually streaming.
There was a problem hiding this comment.
Thank you, updated the PR to include a check is_streaming.
tstokes22
force-pushed
the
fix/windows-dynamic-mousekeys
branch
from
1b707b0 to
99407e1
Compare
…when stream doesn't detect a mouse.
tstokes22
force-pushed
the
fix/windows-dynamic-mousekeys
branch
from
99407e1 to
e3beac6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a dynamic fix that listens for the DBT_DEVNODES_CHANGED message.
It hooks into the WM_DEVICECHANGE window message in main.cpp. When triggered, it calls a new function, platf::check_and_force_cursor_visibility(), which safely checks if a mouse is present.
If no mouse is detected, it toggles the Windows "Mouse Keys" accessibility feature. This forces a system-wide cursor redraw, making the cursor visible on the stream again without affecting user settings.
This same function is now also used at stream startup to unify the cursor handling logic.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist