Skip to content

feat(updates): Update notifications from system tray #4122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

feat(updates): Update notifications from system tray #4122

wants to merge 4 commits into from

Conversation

Nonary
Copy link

@Nonary Nonary commented Aug 1, 2025

Description

Adds capability to send notifications for new versions of Sunshine via the system tray.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 1, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
49 New issues
48 New Code Smells (required ≤ 0)
1 New Vulnerabilities (required ≤ 0)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 9, 2025
View reviewed changes
src/update.cpp
}
struct curl_slist *headers = nullptr;
headers = curl_slist_append(headers, "Accept: application/vnd.github+json");
headers = curl_slist_append(headers, "X-GitHub-Api-Version: 2022-11-28");

Check failure

Code scanning / SonarCloud

Weak SSL/TLS protocols should not be used High

Use stronger SSL and TLS versions See more on SonarQube Cloud
@Nonary
Copy link
Author

Nonary commented Aug 10, 2025

There are some weird bugs going on with the tray that cause it to intermittently break. I am putting this one on hold until I figure out how to fix #4142

@ReenigneArcher ReenigneArcher added the ai PR has signs of heavy ai usage (either indicated by user or assumed) label Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ai PR has signs of heavy ai usage (either indicated by user or assumed)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sunshine: improve update checks
2 participants
@Nonary @ReenigneArcher