Skip to content

Conversation

@tstokes22
Copy link

Added continuous checks for a physical mouse while streaming rather than just at the start of streaming. This fix is intended for particular situations on the windows platform when using a KVM switch that changes the cursor from a hardware cursor to a virtual cursor causing windows to not detect a physical cursor while streaming.

Description

Changed the previous physical mouse checking:

// If there is no mouse connected, enable Mouse Keys to force the cursor to appear
if (!GetSystemMetrics(SM_MOUSEPRESENT))...

to it's own function void enable_mouse_keys();. The function is still called at the end of streaming_will_start() and now in video.cpp to continuously check if a physical mouse is present.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@sonarqubecloud
Copy link

@tstokes22 tstokes22 changed the title Continuous checks for physical mouse while streaming through mousekeys fix(windows): resolve disappearing cursor after KVM switch Jan 7, 2026
@codecov
Copy link

codecov bot commented Jan 7, 2026

Bundle Report

Bundle size has no change ✅

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.39%. Comparing base (c9e0bb8) to head (1629fa2).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/windows/misc.cpp 0.00% 2 Missing ⚠️
src/platform/linux/misc.cpp 0.00% 1 Missing ⚠️
src/video.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #4407    +/-   ##
========================================
  Coverage   15.38%   15.39%            
========================================
  Files          92       92            
  Lines       18993    18997     +4     
  Branches     8769     8770     +1     
========================================
+ Hits         2923     2925     +2     
+ Misses      14938    14415   -523     
- Partials     1132     1657   +525     
Flag Coverage Δ
Archlinux 11.54% <0.00%> (-0.01%) ⬇️
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.64% <0.00%> (-0.02%) ⬇️
Homebrew-ubuntu-22.04 13.95% <0.00%> (+0.12%) ⬆️
Linux-AppImage 11.64% <0.00%> (-0.01%) ⬇️
Windows-AMD64 13.41% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/common.h 28.84% <ø> (ø)
src/platform/linux/misc.cpp 14.94% <0.00%> (-0.03%) ⬇️
src/video.cpp 29.58% <0.00%> (-0.17%) ⬇️
src/platform/windows/misc.cpp 15.61% <0.00%> (-0.04%) ⬇️

... and 39 files with indirect coverage changes

ReenigneArcher
ReenigneArcher previously approved these changes Jan 8, 2026
@ReenigneArcher
Copy link
Member

@ReenigneArcher

This comment was marked as resolved.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants