Skip to content

fix(windows-installer): Add user prompt for Virtual Gamepad #4466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ReenigneArcher wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −2
Draft

fix(windows-installer): Add user prompt for Virtual Gamepad #4466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions cmake/packaging/windows_nsis.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,18 @@ SET(CPACK_NSIS_EXTRA_INSTALL_COMMANDS
nsExec::ExecToLog '\\\"$INSTDIR\\\\scripts\\\\update-path.bat\\\" add'
nsExec::ExecToLog '\\\"$INSTDIR\\\\scripts\\\\migrate-config.bat\\\"'
nsExec::ExecToLog '\\\"$INSTDIR\\\\scripts\\\\add-firewall-rule.bat\\\"'
nsExec::ExecToLog \
'powershell.exe -NoProfile -ExecutionPolicy Bypass -File \\\"$INSTDIR\\\\scripts\\\\install-gamepad.ps1\\\"'
IfFileExists \\\"$INSTDIR\\\\scripts\\\\install-gamepad.ps1\\\" 0 NoGamepad
MessageBox MB_YESNO|MB_ICONQUESTION \
'Do you want to install Virtual Gamepad?$\\r$\\n\
This is required for gamepad input from Moonlight.$\\r$\\n$\\r$\\n\
Note: See considerations at$\\r$\\n\
https://docs.lizardbyte.dev/projects/sunshine/latest/md_docs_2getting__started.html#considerations' \
/SD IDNO IDNO NoGamepad
nsExec::ExecToLog \
'powershell.exe -NoProfile -ExecutionPolicy Bypass -File \
\\\"$INSTDIR\\\\scripts\\\\install-gamepad.ps1\\\"'; \
skipped if no
NoGamepad:
nsExec::ExecToLog '\\\"$INSTDIR\\\\scripts\\\\install-service.bat\\\"'
nsExec::ExecToLog '\\\"$INSTDIR\\\\scripts\\\\autostart-service.bat\\\"'
NoController:
Expand All @@ -29,6 +39,7 @@ set(CPACK_NSIS_EXTRA_UNINSTALL_COMMANDS
nsExec::ExecToLog '\\\"$INSTDIR\\\\scripts\\\\delete-firewall-rule.bat\\\"'
nsExec::ExecToLog '\\\"$INSTDIR\\\\scripts\\\\uninstall-service.bat\\\"'
nsExec::ExecToLog '\\\"$INSTDIR\\\\${CMAKE_PROJECT_NAME}.exe\\\" --restore-nvprefs-undo'
IfFileExists \\\"$INSTDIR\\\\scripts\\\\uninstall-gamepad.ps1\\\" 0 NoGamepad
MessageBox MB_YESNO|MB_ICONQUESTION \
'Do you want to remove Virtual Gamepad?' \
/SD IDNO IDNO NoGamepad
Expand Down
3 changes: 3 additions & 0 deletions docs/getting_started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,9 @@ All shortcuts start with `Ctrl+Alt+Shift`, just like Moonlight.
This can only be changed by modifying the `apps.json` file directly.

### Considerations
* Using virtual input devices may not work in all games.
Some games may also ban you for using virtual input.
Use at your own risk.
* On Windows, Sunshine uses the Desktop Duplication API which only supports capturing from the GPU used for display.
If you want to capture and encode on the eGPU, connect a display or HDMI dummy display dongle to it and run the games
on that display.
Expand Down
Loading