-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
build(deps): bump third-party/build-deps from 814fa85 to 10366be
#4563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
build(deps): bump third-party/build-deps from 814fa85 to 10366be
#4563
Conversation
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4563 +/- ##
==========================================
- Coverage 15.38% 15.32% -0.07%
==========================================
Files 92 92
Lines 18993 18993
Branches 8769 8769
==========================================
- Hits 2923 2911 -12
+ Misses 14938 12748 -2190
- Partials 1132 3334 +2202
Flags with carried forward coverage won't be shown. Click here to find out more. |
Bumps [third-party/build-deps](https://github.com/LizardByte/build-deps) from `814fa85` to `10366be`. - [Commits](LizardByte/build-deps@814fa85...10366be) --- updated-dependencies: - dependency-name: third-party/build-deps dependency-version: 10366be8dbaff9d73004c72dc2a8abd017be2b78 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
34727ea to
48cf74f
Compare
|
|
@ReenigneArcher I think we may need to change our build-deps code to just use the compiled libva for the FFmpeg build without actually publishing the libs and headers into the final The build is failing here because the platform's libva version lacks the Trying to make the library match the headers by linking to the built libva.a from build-deps introduces different issues. Since libva includes a hardcoded default libva driver search path, this yields a build that compiles but fails at runtime because it can't find the libva driver (and we can't hardcode it "properly" ourselves either because distros vary on the correct location for their VA drivers) If we don't expose the newer headers or libs from the libva build in build-deps and just link to what the platform has, I think we should be okay on the versions of libva for the distros we support (anything within ~4 years). Going back further than that will break though, since whole swaths of functionality like AV1 will be missing and we can't fake that with a little helper function like we can for |
|
@cgutman that makes sense. Is it even worth compiling libva in build-deps then, or should we just install it? Homebrew has version 2.23. https://formulae.brew.sh/formula/libva ... though I guess it doesn't matter much. I don't think it adds much time to the total compilation. |



Bumps third-party/build-deps from
814fa85to10366be.Commits
10366befeat(FFmpeg): compile libva dependency (#590)547d228fix(ffmpeg): Add upstreamed MF low latency encoding patch (#587)1d60a89build(deps): bump third-party/FFmpeg/FFmpeg frome360467toec78e95(#586)a66c5bcbuild(deps): bump vmactions/freebsd-vm from 1.3.3 to 1.3.4 (#584)d0cd4f5build(deps): bump vmactions/freebsd-vm from 1.3.2 to 1.3.3 (#583)4e0d6dabuild(deps): bump vmactions/freebsd-vm from 1.3.0 to 1.3.2 (#582)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)