Skip to content

Conversation

@cgutman
Copy link
Contributor

@cgutman cgutman commented Jan 2, 2026

Description

This PR imports the upstreamed patch for the MediaFoundation encoder that we need for LizardByte/Sunshine#4521.

FFmpeg/FFmpeg@126671e

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@cgutman
Copy link
Contributor Author

cgutman commented Jan 2, 2026

Oops, I forgot FFmpeg/FFmpeg@b2910ec was cherry-picked in to release/8.0 already. I'll drop that.

@cgutman cgutman changed the title fix(ffmpeg): Add upstreamed MF encoding patches fix(ffmpeg): Add upstreamed MF low latency encoding patch Jan 2, 2026
@cgutman
Copy link
Contributor Author

cgutman commented Jan 3, 2026

The trailing whitespace that the linter is complaining about is part of the patch format itself, so I think that should be ignored.

@ReenigneArcher
Copy link
Member

I think I ran into this before. I believe the patch still works if you remove the whitespace.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2026

@ReenigneArcher ReenigneArcher merged commit 9d87075 into LizardByte:master Jan 3, 2026
18 checks passed
@ns6089
Copy link

ns6089 commented Jan 4, 2026

Just FYI, big red warning in https://learn.microsoft.com/en-us/windows/win32/medfound/codecapi-avlowlatencymode says

In the current implementation, the Media Foundation H.264 decoder uses the type VT_UI4 for this property. All other implementations, including the H.264 encoder, use the type VT_BOOL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants