Replace Ping functionality with RTT from TCP & export data in CSV via settings #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnzhou
reviewed
Sep 7, 2025
app/src/main/java/com/lcl/lclmeasurementtool/features/mlab/MLabResult.kt
Outdated
Show resolved
Hide resolved
johnnzhou
reviewed
Sep 7, 2025
app/src/main/java/com/lcl/lclmeasurementtool/util/CsvExporter.kt
Outdated
Show resolved
Hide resolved
johnnzhou
reviewed
Sep 7, 2025
app/src/main/java/com/lcl/lclmeasurementtool/util/CsvExporter.kt
Outdated
Show resolved
Hide resolved
johnnzhou
reviewed
Sep 7, 2025
app/src/main/java/com/lcl/lclmeasurementtool/ui/SettingsView.kt
Outdated
Show resolved
Hide resolved
johnnzhou
reviewed
Sep 7, 2025
app/src/main/java/com/lcl/lclmeasurementtool/features/mlab/MLabRunner.kt
Outdated
Show resolved
Hide resolved
Adds validation for empty/invalid cryptographic keys in upload process and improves error handling with specific exception catching.
johnnzhou
reviewed
Sep 28, 2025
app/src/main/java/com/lcl/lclmeasurementtool/features/mlab/MLabRunner.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lcl/lclmeasurementtool/model/viewmodels/SettingsViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/lcl/lclmeasurementtool/model/viewmodels/SettingsViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lcl/lclmeasurementtool/MainActivityViewModel.kt
Outdated
Show resolved
Hide resolved
johnnzhou
reviewed
Sep 30, 2025
app/src/main/java/com/lcl/lclmeasurementtool/sync/UploadWorker.kt
Outdated
Show resolved
Hide resolved
johnnzhou
reviewed
Sep 30, 2025
app/src/main/java/com/lcl/lclmeasurementtool/MainActivityViewModel.kt
Outdated
Show resolved
Hide resolved
johnnzhou
reviewed
Sep 30, 2025
app/src/main/java/com/lcl/lclmeasurementtool/MainActivityViewModel.kt
Outdated
Show resolved
Hide resolved
ananyaa06
commented
Sep 30, 2025
johnnzhou
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has code that has replaced the in-house Ping functionality with RTT values from MLab's TCPInfo as well as code to read the database and export to CSV files through settings