Skip to content

Replace Ping functionality with RTT from TCP & export data in CSV via settings #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Oct 2, 2025
Merged

Replace Ping functionality with RTT from TCP & export data in CSV via settings #14

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
57bb5d3
chore: fix deprecated Android permissions
ananyaa06 Aug 26, 2025
7af43b4
fix: fix json schema for host name response
johnnzhou Aug 26, 2025
c4bec24
feat: cursory attempts at replacing runMlabPing()
ananyaa06 Aug 27, 2025
a405cab
Revert "feat: cursory attempts at replacing runMlabPing()"
ananyaa06 Aug 27, 2025
214fe90
feat(networking): replace custom Ping with ndt7 TCPInfo.RTT
ananyaa06 Aug 27, 2025
4a4e2d4
fix: remove references to in-house Ping from HomeScreen.kt
ananyaa06 Aug 27, 2025
1a4ee13
fix: tcpInfo is null
ananyaa06 Sep 2, 2025
68340fa
Revert "fix: tcpInfo is null"
ananyaa06 Sep 2, 2025
59626ce
fix: rectify problems with measurement
ananyaa06 Sep 2, 2025
9961960
fix: get the ping actually working by fixing callbacks
ananyaa06 Sep 2, 2025
1a47a73
fix: get upload to work
ananyaa06 Sep 3, 2025
7e355c0
fix: make sure upload results update on UI correctly
ananyaa06 Sep 3, 2025
eec3d2b
feat: read the data from the database and generate the csv file when …
ananyaa06 Sep 4, 2025
eb0e9d3
refactor: store specific metrics in MLabResult instead of whole TCPInfo
ananyaa06 Sep 7, 2025
2fb2a96
fix: remove smart casting
ananyaa06 Sep 7, 2025
3dea4e2
refactor: min version is 30 so remove checks
ananyaa06 Sep 7, 2025
78a17d6
refactor: replace stack trace with logging
ananyaa06 Sep 7, 2025
4306449
refactor: remove the wrapping around the imported functions from Sett…
ananyaa06 Sep 7, 2025
25c02de
refactor: make onDownloadProgress and onUploadProgress more consistent
ananyaa06 Sep 7, 2025
2a3b5de
feat: retry mechanism in UploadWorker.kt
ananyaa06 Sep 25, 2025
da8a54d
refactor: add some logging to debug
ananyaa06 Sep 25, 2025
7247dd5
fix: unresolved reference in MainActivityViewModel.kt
ananyaa06 Sep 25, 2025
ebcd23f
feat: add retry mechanism to UploadWorker.kt
ananyaa06 Sep 26, 2025
f18a706
Merge commit 'ebcd23f09e26e41252f5c5acded7a238ed9e1009' into AnanyaDev
ananyaa06 Sep 26, 2025
e8c76b3
refactor: remove old retry code
ananyaa06 Sep 27, 2025
46ea5ea
fix: handle InvalidKeySpecException with proper key validation
ananyaa06 Sep 27, 2025
62627ef
refactor: resolve comments on PR
ananyaa06 Sep 28, 2025
b7e640f
feat: create a test server and some unit tests for UploadWorker
ananyaa06 Sep 29, 2025
50bc709
feat: add README to the test server
ananyaa06 Sep 29, 2025
8da0464
fix: resolve some build errors and PR comments
ananyaa06 Sep 29, 2025
cf8061f
refactor: removing old code for notifications from UploadWorker
ananyaa06 Sep 29, 2025
7682e13
refactor: resolve comment
ananyaa06 Sep 30, 2025
e6c63fe
refactor: remove reporting with no authentication
ananyaa06 Sep 30, 2025
a8696c6
refactor: resolve GitHub comments
ananyaa06 Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions app/src/main/java/com/lcl/lclmeasurementtool/MainActivityViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,12 +419,7 @@ class MainActivityViewModel @Inject constructor(
}

try {
val reportString = if (userData.skT.isEmpty || userData.hPKR.isEmpty) {
Log.d(TAG, "Using no-auth reporting due to missing cryptographic keys (demo mode or incomplete authentication)")
prepareReportDataNoAuth(reportModel)
} else {
prepareReportData(reportModel, userData)
}
val reportString = prepareReportData(reportModel, userData)
val response: ResponseBody = if (reportModel is SignalStrengthReportModel) {
networkApi.uploadSignalStrength(reportString)
} else {
Expand Down
7 changes: 1 addition & 6 deletions app/src/main/java/com/lcl/lclmeasurementtool/model/repository/ConnectivityRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,7 @@ class ConnectivityRepository @Inject constructor(
.flowOn(Dispatchers.IO)
.combine(userDataRepository.userData) { connectivity, preference ->
Log.d(TAG, "upload worker will upload $connectivity")
val reportString = if (preference.skT.isEmpty || preference.hPKR.isEmpty) {
Log.d(TAG, "Using no-auth reporting due to missing cryptographic keys (demo mode or incomplete authentication)")
prepareReportDataNoAuth(connectivity)
} else {
prepareReportData(connectivity, preference)
}
val reportString = prepareReportData(connectivity, preference)
networkApi.uploadConnectivity(reportString)
}
.catch {
Expand Down
7 changes: 1 addition & 6 deletions app/src/main/java/com/lcl/lclmeasurementtool/model/repository/SignalStrengthRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,7 @@ class SignalStrengthRepository @Inject constructor(
.flowOn(Dispatchers.IO)
.combine(userDataRepository.userData) { signalStrength, preference ->
Log.d(TAG, "upload worker will upload $signalStrength")
val reportString = if (preference.skT.isEmpty || preference.hPKR.isEmpty) {
Log.d(TAG, "Using no-auth reporting due to missing cryptographic keys (demo mode or incomplete authentication)")
prepareReportDataNoAuth(signalStrength)
} else {
prepareReportData(signalStrength, preference)
}
val reportString = prepareReportData(signalStrength, preference)
networkApi.uploadSignalStrength(reportString)
}
.catch {
Expand Down