Skip to content

Conversation

Copy link

Copilot AI commented Feb 1, 2026

Applied changes from PR review thread addressing code quality and configuration alignment issues.

Code cleanup:

  • Removed debug console.log statements from DeckIconPicker.client.vue
  • Added explicit ReturnType<typeof useColorMode> | null type annotation to prevent TypeScript any inference
  • Added missing semicolon in PadCfg.ts import for ESLint semi: true compliance

Configuration alignment:

  • Updated .nuxtrc files to use @nuxt/test-utils@3.17.2 matching workspace catalog
  • Changed nuxt.config.ts conditional module loading from import.meta.env.TEST to process.env.TEST || process.env.VITEST for Node runtime compatibility

Minor fixes:

  • Fixed typo in vitest.config.ts comment: "readably slow" → "incredibly slow"
// Before: defeats type-checking, undefined at build time
let colorMode = null;
if (!import.meta.env.TEST) colorMode = useColorMode();
...(!import.meta.env.TEST ? ['@nuxtjs/color-mode'] : [])

// After: explicit type, Node-available flag
let colorMode: ReturnType<typeof useColorMode> | null = null;
if (!import.meta.env.TEST) colorMode = useColorMode();
...(!(process.env.TEST || process.env.VITEST) ? ['@nuxtjs/color-mode'] : [])

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: AAllport <3750120+AAllport@users.noreply.github.com>
@AAllport AAllport marked this pull request as ready for review February 1, 2026 17:57
Copilot AI review requested due to automatic review settings February 1, 2026 17:57
Copilot AI changed the title [WIP] Update dependencies for Nuxt 4 upgrade and related changes Address PR review comments: Remove debug code, fix types, align config Feb 1, 2026
Copilot AI requested a review from AAllport February 1, 2026 17:57
@AAllport AAllport merged commit 9a0beb5 into feature/2026-updates Feb 1, 2026
6 of 8 checks passed
@AAllport AAllport deleted the copilot/sub-pr-58 branch February 1, 2026 17:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request prepares the codebase for a Nuxt 4 upgrade by cleaning up code quality issues, fixing environment variable handling, and aligning dependency versions with the project's catalog configuration.

Changes:

  • Fixed spelling error in vitest.config.ts comment ("readably" → "incredibly")
  • Updated nuxt.config.ts to use process.env instead of import.meta.env for proper Node.js environment variable access
  • Aligned @nuxt/test-utils version to 3.17.2 across both configurator and components packages to match catalog
  • Added missing semicolon in PadCfg.ts for code style consistency
  • Removed debug console.log statements and added explicit typing for colorMode variable in DeckIconPicker component

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/localdeck-configurator/vitest.config.ts Corrected spelling in comment from "readably" to "incredibly"
packages/localdeck-configurator/nuxt.config.ts Updated environment variable check from import.meta.env to process.env for proper Node.js configuration file usage
packages/localdeck-configurator/.nuxtrc Aligned @nuxt/test-utils version from 3.23.0 to 3.17.2 to match catalog specification
packages/localdeck-components/src/utils/PadCfg.ts Added missing semicolon to import statement for consistency with project's eslint rules
packages/localdeck-components/src/components/DeckIconPicker.client.vue Removed debug console.log statements and added explicit TypeScript type for colorMode variable
packages/localdeck-components/.nuxtrc Aligned @nuxt/test-utils version from 3.23.0 to 3.17.2 to match catalog specification

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants