-
Notifications
You must be signed in to change notification settings - Fork 182
Clean warnings #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Clean warnings #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d921748 to
d703b81
Compare
d703b81 to
4fd3b74
Compare
e039ad5 to
3a3fed7
Compare
3a3fed7 to
354d24c
Compare
…ems: - ToString() may be overridden in a class, returning a custom string instead of the type name. - Not guaranteed to return the type name, which is what ObjectDisposedException expects. - Returns the runtime type of the instance, ensuring accuracy. - Works even in derived classes, reflecting the actual type rather than the base type. - Recommended by Microsoft for ObjectDisposedException.
Solved IDE0035
Solved IDE0058
Fixed warnings
baaa9e8 to
1a3a435
Compare
…into clean_warnings # Conflicts: # src/LogExpert.UI/Controls/BufferedDataGridView.cs # src/LogExpert.UI/Controls/LogWindow/LogWindowPublic.cs # src/LogExpert.UI/Extensions/BookmarkExporter.cs # src/LogExpert/Classes/LogExpertProxy.cs # src/LogExpert/Program.cs
7c78ec0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Hirogen this should be merged only after the dllimport (PR #395) branch is merged