Added and changed rules #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Hirogen merged 1 commit into LogExperts:Development from RandallFlagg:editor_config

Jun 15, 2025

Merged

Added and changed rules #421

Added and changed rules

Annotations

10 warnings

src/SftpFileSystemx64/SftpLogFileInfo.cs#L177

Modify 'get_FileExists' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)

src/ColumnizerLib/Extensions/LogLineExtensions.cs#L7

In externally visible method 'string LogLineExtensions.ToClipBoardText(ILogLine logLine)', validate parameter 'logLine' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)

src/ColumnizerLib/Column.cs#L21

Initialize all static fields in 'Column' when those fields are declared and remove the explicit static constructor (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1810)

src/ColumnizerLib/Extensions/LogLineExtensions.cs#L7

The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'ILogLine.ToClipBoardText()' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)

src/ColumnizerLib/Column.cs#L80

Make 'Column' sealed (a breaking change if this class has previously shipped), implement the method non-explicitly, or implement a new method that exposes the functionality of 'LogExpert.ITextValue.get_Text' and is visible to derived classes (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1033)

src/ColumnizerLib/IFileSystemPlugin.cs#L42

Change the type of parameter 'uriString' of method 'IFileSystemPlugin.GetLogfileInfo(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.GetLogfileInfo(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)

src/ColumnizerLib/IFileSystemPlugin.cs#L34

Change the type of parameter 'uriString' of method 'IFileSystemPlugin.CanHandleUri(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.CanHandleUri(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)

src/ColumnizerLib/LineEntry.cs#L8

LineEntry should override the equality (==) and inequality (!=) operators (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1815)

src/ColumnizerLib/LineEntry.cs#L8

LineEntry should override Equals (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1815)

src/ColumnizerLib/IXmlLogConfiguration.cs#L33

Rename virtual/interface member IXmlLogConfiguration.Namespace so that it no longer conflicts with the reserved language keyword 'Namespace'. Using a reserved keyword as the name of a virtual/interface member makes it harder for consumers in other languages to override/implement the member. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1716)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added and changed rules #421

Uh oh!

Uh oh!

Added and changed rules #421

Uh oh!

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...