Skip to content

sync alert jobs followup: remove raises #3087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ziinc merged 1 commit into from
Jan 14, 2026
Merged

sync alert jobs followup: remove raises #3087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions lib/logflare/alerting.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,16 +208,11 @@ defmodule Logflare.Alerting do
Creates an alert job struct (but does not insert it into the scheduler.)
"""
@spec create_alert_job_struct(AlertQuery.t()) :: Quantum.Job.t()
def create_alert_job_struct(%AlertQuery{} = alert_query) do
%AlertQuery{id: alert_query_id, cron: cron} = alert_query

if is_nil(alert_query_id) do
raise ArgumentError, "AlertQuery is missing id: #{inspect(alert_query)}"
end

def create_alert_job_struct(%AlertQuery{id: alert_query_id} = alert_query)
when not is_nil(alert_query_id) do
AlertsScheduler.new_job(run_strategy: Quantum.RunStrategy.Local)
|> Quantum.Job.set_task({__MODULE__, :run_alert, [alert_query_id, :scheduled]})
|> Quantum.Job.set_schedule(Crontab.CronExpression.Parser.parse!(cron))
|> Quantum.Job.set_schedule(Crontab.CronExpression.Parser.parse!(alert_query.cron))
|> Quantum.Job.set_name(to_job_name(alert_query))
end

Expand Down Expand Up @@ -426,9 +421,6 @@ defmodule Logflare.Alerting do

{_name, node} ->
Cluster.Utils.rpc_call(node, func)

nil ->
raise "Alerting scheduler node not found"
end
end

Expand Down
Loading