fix(compare): exclude git-ignored files and improve git command security#137
Merged
fix(compare): exclude git-ignored files and improve git command security#137
Conversation
- Fix false positives where git-ignored files appeared as "added" components - Filter git-ignored files from comparison results and recalculate counts - Add isGitIgnored() and filterGitIgnoredFiles() utilities Security: Refactor execGit() to use spawn instead of exec to prevent command injection. spawn executes without shell interpretation and properly handles file paths with spaces/special characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix false positives in git baseline comparisons where git-ignored
.ts/.tsxfiles (e.g.next-env.d.ts) appeared as added components.Git-ignored files are now filtered from comparison results, ensuring accurate drift detection when files exist in the working directory but are not tracked by git.
Additional security improvement:
execGit()now usesspawninstead ofexecType of Change
Architectural Impact
Testing
Related Issues
Fixes false positives in git baseline comparison.
Checklist
mainAdditional Notes
Adds
isGitIgnored()andfilterGitIgnoredFiles()utilities to ensure git-ignored files are excluded from comparison results and summary counts are recalculated correctly.Security improvement:
execGit()now usesspawninstead ofexec, avoiding shell interpretation and reducing potential command injection risk when executing git commands with file paths or refs.