feat(compare): enhance props and emits handling#142
Merged
Conversation
- Store full prop and emit objects with types instead of keys - Filter invalid prop/emit identifiers - Improve detection of added and removed props/emits - Update display logic for new structure - Extend unit tests for props/emits comparison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhances the comparison logic for
propsandemitsto support full object structures instead of only key names.Previously, comparison operated only on prop/event names. This change stores and compares the full objects (including types), allowing more accurate detection of structural changes while maintaining deterministic behavior.
Key improvements include filtering invalid identifiers, improving change detection, and updating the display layer accordingly.
Type of Change
Architectural Impact
If contract/output changed, explain the impact on:
propsandemitsnow store full objects (including types) instead of only keys.Testing
Unit tests were extended to cover the new props/emits structure and ensure correct detection of added and removed entries.
Related Issues
None.
Checklist
mainAdditional Notes
This change improves structural accuracy of comparison results while preserving deterministic output ordering.