⚡ Bolt: Optimize sensitive data redaction#1357
Conversation
Adds an early return check to `redact_sensitive_data` to skip regex processing for strings that do not contain potential secret markers ("sk-" or "Bearer"). This improves performance for safe strings by ~5x (0.11s -> 0.02s per 100k iters).
Co-authored-by: LokiMetaSmith <5054116+LokiMetaSmith@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added an early return check in
redact_sensitive_datato bypass expensive regex substitutions when no sensitive patterns ("sk-", "Bearer") are present in the text.🎯 Why:
redact_sensitive_datais called on every log line and potentially large data structures (viasanitize_data). Most data is "safe", so avoiding the regex engine overhead for these cases yields significant cumulative savings.📊 Impact: Reduces execution time for safe text by ~80% (~5x speedup).
🔬 Measurement: Benchmarked with 100k iterations. Safe text processing dropped from 0.11s to 0.02s. Secret text processing remained effectively unchanged. verified with
tests/unit/test_security.py.PR created automatically by Jules for task 5898916240253635867 started by @LokiMetaSmith