Skip to content

Use Handles to check whether to draw gizmos or not #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Looooong merged 1 commit into from
Jul 7, 2020
Merged

Use Handles to check whether to draw gizmos or not #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
### Fixed

- Fixed the gizmos being drawn in Game View.
- Fixed camera stacking.

## [0.0.1]

Expand Down
4 changes: 3 additions & 1 deletion Runtime/SRP/VXGIRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,12 @@ void RenderGBuffers(ScriptableRenderContext renderContext, Camera camera) {
[System.Diagnostics.Conditional("UNITY_EDITOR")]
void RenderGizmos(ScriptableRenderContext renderContext, Camera camera, GizmoSubset gizmoSubset)
{
if (UnityEditor.SceneView.currentDrawingSceneView?.drawGizmos ?? false)
#if UNITY_EDITOR
if (UnityEditor.Handles.ShouldRenderGizmos())
{
renderContext.DrawGizmos(camera, gizmoSubset);
}
#endif
}

void RenderLighting(ScriptableRenderContext renderContext, Camera camera, VXGI vxgi) {
Expand Down