Skip to content

Fix camera clear flags not handled properly in fallback rendering #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Looooong merged 1 commit into from
Jul 28, 2020
Merged

Fix camera clear flags not handled properly in fallback rendering #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
- Fixed the gizmos being drawn in Game View.
- Fixed camera stacking.
- Fixed freezing when starting editor.
- Fixed camera clear flags not handled properly in fallback rendering.

## [0.0.1]

Expand Down
8 changes: 6 additions & 2 deletions Runtime/SRP/VXGIRenderPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,16 @@ void RenderFallback(ScriptableRenderContext renderContext, Camera camera) {

renderContext.SetupCameraProperties(camera);

_command.ClearRenderTarget(true, true, camera.backgroundColor);
_command.ClearRenderTarget(
(camera.clearFlags & CameraClearFlags.Depth) != 0,
camera.clearFlags == CameraClearFlags.Color,
camera.backgroundColor
);
renderContext.ExecuteCommandBuffer(_command);
_command.Clear();

renderContext.DrawRenderers(cullingResults, ref drawingSettings, ref _filteringSettings);
renderContext.DrawSkybox(camera);
if (camera.clearFlags == CameraClearFlags.Skybox) renderContext.DrawSkybox(camera);
renderContext.InvokeOnRenderObjectCallback();

TriggerCameraCallback(camera, "OnPostRender", Camera.onPostRender);
Expand Down