sdtype_adapter refactor #1753
Merged
sdtype_adapter refactor #1753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a stringstream to avoid the explicit conversions to string. Also, generate from the sd.cpp struct, to reduce dependencies on the global context fields.
Most image generation parameters are not customizable through the API, and their values simply repeat the default set by sd.cpp. So, remove them from the SDParams struct, and place the needed constant values directly on the code. Also, print debug information directly from the sd.cpp parameters. And to help with type mismatches and general readability, replace the fromatting with stringstreams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1732 , applying the changes to
sdtype_adapter.cppthat don't depend on the new code, but should help with this and future updates.The main purpose is removal of the generation parameters that Koboldcpp leave at their default values. The new revisions introduce several additional parameters, and there isn't much point in keeping them all mirrored inside the
SDParamsstruct.I also moved the debug prints closer to the sd.cpp calls, to help tracking what is actually sent to the library, and adapted the generation metadata to work with the sd.cpp parameter struct, to help including whichever value we're setting by default.