Skip to content

fix(ios): correct stateMachineUnsubscribe method name and signature#30

Merged
theashraf merged 2 commits intoLottieFiles:mainfrom
orangec-at:fix/ios-state-machine-unsubscribe-typo
Mar 13, 2026
Merged

fix(ios): correct stateMachineUnsubscribe method name and signature#30
theashraf merged 2 commits intoLottieFiles:mainfrom
orangec-at:fix/ios-state-machine-unsubscribe-typo

Conversation

@orangec-at
Copy link
Contributor

Description

Fixes iOS compilation error in DotlottieReactNativeViewManager.swift

Problem

  • Method name had incorrect capitalization: stateMachineUnSubscribe (capital S)
  • Incorrect parameter label usage: observer: should not be used

Changes

  • Fixed method name: stateMachineUnSubscribestateMachineUnsubscribe
  • Removed parameter label: observer: stateMachineObserverstateMachineObserver

Error Fixed

Value of type 'DotLottieAnimation' has no member 'stateMachineUnSubscribe'

Testing

  • ✅ iOS build compiles successfully after fix
  • ✅ Matches the actual method signature in DotLottieAnimation class (line 629 in LottieFiles-dotLottie-ios)

Related

  • Affects version: 0.7.0
  • File: ios/DotlottieReactNativeViewManager.swift:131

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2025

⚠️ No Changeset found

Latest commit: c68f878

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@theashraf theashraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orangec-at Thanks for the fix! However, the example iOS build is failing on CI

@orangec-at
Copy link
Contributor Author

Follow-up (clean):

  • podspec dependency is now ~> 0.11 for LottieFiles-dotLottie-iOS
  • example/ios/Podfile.lock has been regenerated and now resolves LottieFiles-dotLottie-iOS (0.11.1)

This matches the stateMachineUnsubscribe API used in this PR and should fix the iOS example CI build mismatch.

@theashraf theashraf merged commit cc0a738 into LottieFiles:main Mar 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants