fix: add number to source prop type to support require() assets#40
Merged
fix: add number to source prop type to support require() assets#40
Conversation
The source prop type now accepts number in addition to string and
{ uri: string }, matching React Native's require() asset resolution
which returns numeric asset IDs. The runtime handling via
Image.resolveAssetSource() already existed in parseSource(); this
change aligns the TypeScript types with that behavior.
Fixes #39
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numberto thesourceprop type inDotlottieReactNativeProps(bothDotLottie.tsxandDotLottie.web.tsx) and updates theparseSourcefunction signature inutils.tsto matchrequire('./animation.lottie')returns a numeric asset ID — the runtime handling viaImage.resolveAssetSource()already existed inparseSource, but TypeScript rejected the usage becausenumberwas missing from the type unionDotlottieNativeProps(the raw native view interface) is intentionally left unchanged — thesourceis always resolved to astringbefore being passed to the native bridgeFixes #39
Test plan
source={require('./animation.lottie')}to<DotLottie>— TypeScript should accept it without errorsImage.resolveAssetSource()