Merged
Conversation
It was unsealed in case we wanted to have some lab that re-implements Cons and Empty, but it's better to keep this one sealed and if we ever end up doing that, we'll just have students implement the interface as well.
For consistency with other methods
We need it for optics
- Lenses for each component - Traversals for components of type Sequence
- Move all demo to the example package - Fix octaves (they've been wrong for several years!) - Reformats
These are covered by the tests already
- Make all variables final where possible - Add final modifier to all classes - Add private constructor to all classes - Make all class methods other than main private - Allow to run only a specific subsets of demo from Application
java.lang.IO is now a thing and it's going to clash with jtamaro.io.IO when students work in their IDEs. Let's refactor the big IO class into 3, each one focusing on performing IO in some specific way: - GraphicsIO: interacting with the Java GUI - FilesIO: interacting with files - StdIO: interacting with stdin and stderr
- Add more documentation - Rename FilmStripCanvas to GuiFilmStripCanvas to match naming of other classes - Move Graphics#renderableColor to Colors#toAwtColor
- Class names are in bold - Colors now have the #RRGGBB part of their textual representation colored with the actual color - Field names are dimmed - Children begin "inline" rather than on a new line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.