Fixed wrong index incrementing while parsing strings#5
Merged
LucHeart merged 1 commit intoLucHeart:masterfrom Sep 8, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an index incrementing bug in string parsing for OSC (Open Sound Control) packets. The issue was that the string parsing method didn't correctly advance the index after reading a string, leading to parsing errors.
- Modified
GetStringmethod to return the new index position via anoutparameter - Updated string and symbol parsing logic to use the corrected index advancement
- Added comprehensive test coverage for string padding scenarios
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CoreOSC/OscPacketUtils.cs | Added out int newIndex parameter to GetString method to properly track parsing position |
| CoreOSC/OscMessage.cs | Updated string and symbol parsing to use the corrected index from GetString method |
| CoreOSC.Tests/ParseTest.cs | Added new test case to verify correct string parsing with various padding scenarios |
| CoreOSC.Tests/ParseTest.TestStringPadding.verified.txt | Expected test output for the new string padding test |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
LucHeart
approved these changes
Sep 8, 2025
This was referenced Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.