Add multi-node scaling for match template program#94
Merged
jdickerson95 merged 11 commits intoLucaslab-Berkeley:development_v1.1from Sep 20, 2025
Merged
Conversation
Member
Author
|
Closes #89 |
Member
Author
|
@jdickerson95 I'm using development_v1.1 as a quasi-staging branch for the new backend changes, but I think this PR is adding enough that it warrants a brief review to ensure what I'm proposing to add makes sense. |
jdickerson95
requested changes
Sep 16, 2025
Contributor
jdickerson95
left a comment
There was a problem hiding this comment.
Just remove the unnecessary .cpu() (unless they are necessary) and then I'm happy for it to be merged.
d5bcf92
into
Lucaslab-Berkeley:development_v1.1
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds new feature for running the match template program across multi-node, multi-GPU systems by using the
torch.distributedpackage. New filerun_distributed_match_template.pyis necessary for setting up the distributed environment and simplifying codepaths for the more common single-node, multi-GPU runs.Todo before merging
clickoptions to the Python script