AndroidMopups: GetTopFragmentDecorView CurrentActivity may be null#160
Open
Pavesi99 wants to merge 5 commits intoLuckyDucko:masterfrom
Open
AndroidMopups: GetTopFragmentDecorView CurrentActivity may be null#160Pavesi99 wants to merge 5 commits intoLuckyDucko:masterfrom
Pavesi99 wants to merge 5 commits intoLuckyDucko:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a delay in navigation on Android by revising the asynchronous handling of fragment decor views for popup pages. Key changes include:
- Implementing an async retry mechanism when retrieving the top fragment decor view.
- Updating AddAsync and RemoveAsync methods to use the new asynchronous retrieval logic.
- Removing unused static variables from the implementation.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
adding comments
Author
|
@LuckyDucko I added the required changes, please review and approve. |
Pavesi99
changed the title
Author
|
Hi @LuckyDucko does it look good? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a loop with 5 attempts to fixe issue on GetTopFragmentDecorView where CurrentActivity is null after attach a file
#162