MySQL session store #499

oliverbarnes · 2025-06-25T20:45:22Z

Closes #464

Demo on https://github.com/oliverbarnes/pavex_mysql_sessions_demo

Follows the Postgres and SQLite session store implementations.

Key differences below, Claude generated (let me know if it's a bit much with the emojis and all):

🗄️ Database Schema Differences

MySQL

CREATE TABLE IF NOT EXISTS sessions (
    id CHAR(36) PRIMARY KEY,           -- UUID as string
    deadline BIGINT NOT NULL,          -- Unix timestamp (seconds)
    state JSON NOT NULL,               -- JSON column type
    INDEX idx_sessions_deadline (deadline)
);

PostgreSQL

CREATE TABLE IF NOT EXISTS sessions (
    id UUID PRIMARY KEY,               -- Native UUID type
    deadline TIMESTAMPTZ NOT NULL,     -- Timezone-aware timestamp
    state JSONB NOT NULL               -- Binary JSON (more efficient)
);
-- Separate index creation with conditional logic
CREATE INDEX idx_sessions_deadline ON sessions(deadline);

⏰ Time Handling Differences

MySQL

Uses Unix timestamps (BIGINT) for deadline storage
Uses UNIX_TIMESTAMP() function for current time comparisons
Example: WHERE deadline > UNIX_TIMESTAMP()

PostgreSQL

Uses native timestamp with timezone (TIMESTAMPTZ)
Uses (now() AT TIME ZONE 'UTC') for current time comparisons
Example: WHERE deadline > (now() AT TIME ZONE 'UTC')

🔧 SQL Parameter Binding

MySQL

Uses positional parameters with ? placeholders
Example: INSERT INTO sessions (id, deadline, state) VALUES (?, ?, ?)

PostgreSQL

Uses numbered parameters with $1, $2, $3 placeholders
Example: INSERT INTO sessions (id, deadline, state) VALUES ($1, $2, $3)

🚨 Error Code Handling

MySQL

// MySQL error code for duplicate entry
if e.number() == 1062 {
    return Err(DuplicateIdError { id: id.to_owned() });
}

PostgreSQL

// PostgreSQL error code for unique constraint violation
if e.code() == "23505" && e.column() == Some("id") {
    return Err(DuplicateIdError { id: id.to_owned() });
}

📦 Framework Integration

MySQL

No dedicated kit - users must manually register components
Only exports MySqlSessionStore
Users need to handle pool registration and session setup manually

PostgreSQL

Has PostgresSessionKit - provides convenient registration
Exports both PostgresSessionStore and PostgresSessionKit
Kit handles automatic component registration with PostgresSessionKit::new().register(&mut bp)

🗂️ JSON Storage

MySQL

Uses JSON column type (MySQL 5.7.8+)
Text-based JSON storage
MySQL 8.0+ recommended for better performance

PostgreSQL

Uses JSONB column type (binary JSON)
More efficient storage and querying
Built-in JSON operators and indexing support

🛠️ Migration Complexity

MySQL

Simple: Single CREATE TABLE IF NOT EXISTS statement
Index created inline with table

PostgreSQL

Complex: Uses PL/pgSQL block for conditional index creation
Checks pg_indexes system table to avoid duplicate indexes
More robust but verbose migration logic

📋 Version Requirements

MySQL

Requires MySQL 5.7.8+ or MariaDB 10.2+ for JSON support
MySQL 8.0+ recommended for optimal JSON performance

PostgreSQL

Standard PostgreSQL features (UUID, JSONB, TIMESTAMPTZ)
More predictable cross-version compatibility

oliverbarnes · 2025-07-07T13:49:34Z

Looking into the build errors.

…able

oliverbarnes · 2025-07-07T21:47:10Z

@LukeMathWalker from what I gathered it's safe to ignore RUSTSEC-2023-0071, while there's no patch available. This fixes https://github.com/LukeMathWalker/pavex/actions/runs/16118570900/job/45478226401?pr=499.

I've gone ahead and submitted the update to deny.toml, let me know if you think otherwise? I'm looking into the workspace hack issue

oliverbarnes · 2025-07-07T21:55:32Z

Conflicts resolved and build fixed.

LukeMathWalker · 2025-07-24T08:59:26Z

@LukeMathWalker from what I gathered it's safe to ignore RUSTSEC-2023-0071, while there's no patch available. This fixes https://github.com/LukeMathWalker/pavex/actions/runs/16118570900/job/45478226401?pr=499.

I've gone ahead and submitted the update to deny.toml, let me know if you think otherwise? I'm looking into the workspace hack issue

I don't particularly love it because it doesn't allow us to distinguish between silencing the advisory for that specific link in our dependency tree and silencing the advisory for any usage of the rsa crate.
But that's a limitation of the tool, so for now we'll live with it.

libs/pavex_session_sqlx/src/mysql.rs

oliverbarnes · 2025-07-25T18:31:06Z

@LukeMathWalker from what I gathered it's safe to ignore RUSTSEC-2023-0071, while there's no patch available. This fixes https://github.com/LukeMathWalker/pavex/actions/runs/16118570900/job/45478226401?pr=499.
I've gone ahead and submitted the update to deny.toml, let me know if you think otherwise? I'm looking into the workspace hack issue

I don't particularly love it because it doesn't allow us to distinguish between silencing the advisory for that specific link in our dependency tree and silencing the advisory for any usage of the rsa crate. But that's a limitation of the tool, so for now we'll live with it.

Agree, I don't love it at all. But don't see an alternative

# Conflicts: # libs/Cargo.lock # libs/pavex_session_sqlx/Cargo.toml # libs/px_workspace_hack/Cargo.toml

This reverts commit 644e96b.

oliverbarnes · 2025-07-25T20:00:46Z

After merging main, fixing conflicts and running hakari, I see a bunch of packages' Cargo.toml updated with

px_workspace_hack = { version = "0.1", path = "../px_workspace_hack" }

And the top level libs/Cargo.toml has several px_workspace_hack that aren't there on latest main.

I'm wondering if the conflict resolution regressed the workspace hack somehow. Gonna investigate and update here.

LukeMathWalker · 2025-07-26T09:04:07Z

After merging main, fixing conflicts and running hakari, I see a bunch of packages' Cargo.toml updated with
px_workspace_hack = { version = "0.1", path = "../px_workspace_hack" }
And the top level libs/Cargo.toml has several px_workspace_hack that aren't there on latest main.

I'm wondering if the conflict resolution regressed the workspace hack somehow. Gonna investigate and update here.

I had to merge #512 to re-enable the hack after the release. That should solve the issue.

# Conflicts: # libs/Cargo.lock # libs/pavex_bp_schema/Cargo.toml # libs/pavex_tracing/Cargo.toml # libs/px_workspace_hack/Cargo.toml

oliverbarnes · 2025-07-26T12:24:34Z

👍 I see, merged!

libs/pavex_session_sqlx/src/mysql.rs

Co-authored-by: Luca Palmieri <[email protected]>

This reverts commit aada453.

This reverts commit e25ac11.

This reverts commit 754e0f0.

This reverts commit 32a7c0b.

This reverts commit e6efc98.

LukeMathWalker · 2025-08-09T13:02:45Z

libs/pavex_session_sqlx/tests/mysql.rs

+    // Verify the original data is still there (not overwritten)
+    let loaded_after = store.load(&session_id).await.unwrap().unwrap();
+    for (key, expected_value) in &state {
+        assert_eq!(
+            loaded_after.state.get(key).unwrap(),
+            expected_value,
+            "Original data should be preserved when session exists"
+        );
+    }


That's not the property we want. It just happens to work because you have created the conflicted state starting from the existing one.
Let's modify the test case to remove this overlap and check that we don't have anything else in the new state beyond the newly created session state.

Arg, well caught. Will fix

Done. Added some comments to the implementation for clarity on the decision to keep simple upserts.

oliverbarnes · 2025-08-12T10:43:01Z

Build is failing due to RUSTSEC-2025-0047, which has been fixed in slab v0.4.11. Looks like it's a dependency of Tokio, but there's no new release for it with the new slab.

I tried adding it explicitly to the top level Cargo.toml, but Cargo.lock doesn't seem to update after building.

I suspect I may be missing something about Rust dependency management here...

LukeMathWalker · 2025-08-23T18:52:33Z

Solved the issue and made a few final tweaks in #532. Merged!

oliverbarnes added 7 commits June 25, 2025 17:43

MySQL session store

f68d83c

Move tests to separate directory and file

e4c3def

Remove tests that don't hit the db

6b0bd1c

Not happy with this solution yet, but tests are working now

af9097d

Simplify database setup in tests

2ec4dfc

Serial tests

3954c3a

Avoid serial by changing tests around expired sessions

a813fcd

oliverbarnes mentioned this pull request Jun 26, 2025

Add pavex_session_redis lib for Redis-based session management #498

Closed

oliverbarnes marked this pull request as ready for review June 27, 2025 01:47

oliverbarnes added 3 commits June 29, 2025 21:14

Add unhappy path

ca8cda2

Rename test file to be consistent with sqlite tests naming

10e9b94

Merge branch 'main' into mysql-session-store

8a31dc6

Ignore RUSTSEC-2023-0071 advisory while there's no upgrade path avail…

9146611

…able

cargo hakari generate

a053997

LukeMathWalker reviewed Jul 24, 2025

View reviewed changes

libs/pavex_session_sqlx/src/mysql.rs Outdated Show resolved Hide resolved

Make mysql pool private and update tests accordingly

7c450e8

oliverbarnes added 5 commits July 25, 2025 20:38

Merge branch 'main' into mysql-session-store

281b96e

# Conflicts: # libs/Cargo.lock # libs/pavex_session_sqlx/Cargo.toml # libs/px_workspace_hack/Cargo.toml

cargo hakari manage-deps

644e96b

Revert "cargo hakari manage-deps"

8a19c8f

This reverts commit 644e96b.

cargo hakari generate

d4ab6da

cargo hakari manage-deps

02ccd36

Merge branch 'main' into mysql-session-store

102eb1a

# Conflicts: # libs/Cargo.lock # libs/pavex_bp_schema/Cargo.toml # libs/pavex_tracing/Cargo.toml # libs/px_workspace_hack/Cargo.toml

oliverbarnes requested a review from LukeMathWalker July 28, 2025 23:38

LukeMathWalker reviewed Aug 5, 2025

View reviewed changes

libs/pavex_session_sqlx/src/mysql.rs Show resolved Hide resolved

oliverbarnes and others added 11 commits August 5, 2025 19:58

Only update if existing record is expired

e6efc98

Co-authored-by: Luca Palmieri <[email protected]>

Missing quotes

32a7c0b

Return duplicate id error when existing record is current

aada453

Revert "Return duplicate id error when existing record is current"

46bd55b

This reverts commit aada453.

Use affected rows count to return duplicate id error

754e0f0

Debug

e25ac11

Revert "Debug"

adfec5e

This reverts commit e25ac11.

Revert "Use affected rows count to return duplicate id error"

bae8ae6

This reverts commit 754e0f0.

Revert "Missing quotes"

80b4073

This reverts commit 32a7c0b.

Revert "Only update if existing record is expired"

d1af77e

This reverts commit e6efc98.

Merge branch 'main' into mysql-session-store

92df3cc

LukeMathWalker reviewed Aug 9, 2025

View reviewed changes

oliverbarnes added 4 commits August 9, 2025 14:09

Remove unneeded duplicate id error clause on session creation

32432fc

Document decision to keep simple upserts on conflicting ids

f8e6556

Fix conflicting id test

fbe38f6

Merge branch 'main' into mysql-session-store

0777395

LukeMathWalker closed this Aug 23, 2025

MySQL session store #499

MySQL session store #499

Uh oh!

Conversation

oliverbarnes commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🗄️ Database Schema Differences

MySQL

PostgreSQL

⏰ Time Handling Differences

MySQL

PostgreSQL

🔧 SQL Parameter Binding

MySQL

PostgreSQL

🚨 Error Code Handling

MySQL

PostgreSQL

📦 Framework Integration

MySQL

PostgreSQL

🗂️ JSON Storage

MySQL

PostgreSQL

🛠️ Migration Complexity

MySQL

PostgreSQL

📋 Version Requirements

MySQL

PostgreSQL

Uh oh!

oliverbarnes commented Jul 7, 2025

Uh oh!

oliverbarnes commented Jul 7, 2025

Uh oh!

oliverbarnes commented Jul 7, 2025

Uh oh!

LukeMathWalker commented Jul 24, 2025

Uh oh!

Uh oh!

oliverbarnes commented Jul 25, 2025

Uh oh!

oliverbarnes commented Jul 25, 2025

Uh oh!

LukeMathWalker commented Jul 26, 2025

Uh oh!

oliverbarnes commented Jul 26, 2025

Uh oh!

Uh oh!

LukeMathWalker Aug 9, 2025

Choose a reason for hiding this comment

Uh oh!

oliverbarnes Aug 9, 2025

Choose a reason for hiding this comment

Uh oh!

oliverbarnes Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

oliverbarnes commented Aug 12, 2025

Uh oh!

LukeMathWalker commented Aug 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

oliverbarnes commented Jun 25, 2025 •

edited

Loading