feat(docs): Add warning about using Tailwind CSS v4.0 #160
Conversation
…nt instructions to Tailwind CSS v3.* instructions
WalkthroughThe pull request introduces documentation updates related to Tailwind CSS compatibility. A new Changes
Assessment against linked issues
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/LumexUI.Docs.Client/Components/Layouts/InstallationLayout.razor (1)
40-45: Consider adding a version recommendation.The warning effectively communicates the compatibility issue, but it would be helpful to explicitly recommend which Tailwind CSS version users should use instead (e.g., v3.x as mentioned in the PR description).
<Callout Variant="@CalloutVariant.Warning"> Please be aware that LumexUI isn't fully compatible with Tailwind CSS v4.0 at this time. If this is the - version you plan on using, proceed at your own risk. More information can be found in + version you plan on using, proceed at your own risk. We recommend using Tailwind CSS v3.x instead. More information can be found in <LumexLink Href="https://github.com/LumexUI/lumexui/issues/156" External="true">this Github conversation</LumexLink>. </Callout>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/LumexUI.Docs.Client/Components/Layouts/InstallationLayout.razor(1 hunks)docs/LumexUI.Docs.Client/Pages/Getting Started/Installation.razor(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- docs/LumexUI.Docs.Client/Pages/Getting Started/Installation.razor
🔇 Additional comments (1)
docs/LumexUI.Docs.Client/Components/Layouts/InstallationLayout.razor (1)
40-45: Verify the GitHub issue reference.The implementation looks good, but there's a discrepancy in the issue number. The PR objectives mention issue #157, but the code links to #156. Please verify which issue number is correct.
✅ Verification successful
The GitHub issue reference is correct.
The code correctly links to issue #156, which is the main feature request discussing Tailwind CSS v4.0 compatibility. Issue #157 is the PR implementing these changes and closes #156.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify which issue contains the Tailwind CSS v4.0 compatibility discussion # Check both issues to determine which one is correct echo "Checking issue #156" gh issue view 156 --json title,body echo "Checking issue #157" gh issue view 157 --json title,bodyLength of output: 3707
…kages path on a machine
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
==========================================
- Coverage 96.95% 94.37% -2.58%
==========================================
Files 70 98 +28
Lines 1542 2397 +855
Branches 150 303 +153
==========================================
+ Hits 1495 2262 +767
- Misses 28 75 +47
- Partials 19 60 +41 ☔ View full report in Codecov by Sentry. |
|
Thank you, @aurepereira ❤️ P.S. Finally able to merge! The build was failing yesterday for no apparent reason. |
aurepereira
deleted the
feat/156-add-warning-to-intallation-instructions
branch
|
@desmondinho you're welcome! Hope I can contribute beyond just amending some documentation. Cheers! |
2 participants
Add warning about using Tailwind CSS v4.0
Description
This PR adds a warning in the installation steps about limited compatibility with Tailwind CSS v4.0.
Partially closes #156
What's been done?
Checklist
Additional Notes
Summary by CodeRabbit
Summary by CodeRabbit
Calloutcomponent in the installation layout to highlight LumexUI's compatibility issues with Tailwind CSS v4.0.