fix(theme): remove extra shade (950) from the color scales for consistency in dark mode

[desmondinho]

Description

Closes #197

This PR removes the extra 950 shade from the theme color scales to maintain an even number of shades. This ensures that when a scale is reversed for dark mode, it provides a sufficiently contrasting shade.

For example:

Before

// light mode

foreground-50 (shade 50 of the scale)
foreground-100 (shade 100 of the scale)
foreground-200 (shade 200 of the scale)
foreground-300 (shade 300 of the scale)
foreground-400 (shade 400 of the scale)
foreground-500 (shade 500 of the scale) <---
foreground-600 (shade 600 of the scale)
foreground-700 (shade 700 of the scale)
foreground-800 (shade 800 of the scale)
foreground-900 (shade 900 of the scale)
foreground-950 (shade 950 of the scale)

// dark mode (reversed light mode)

foreground-50 (shade 950 of the scale)
foreground-100 (shade 900 of the scale)
foreground-200 (shade 800 of the scale)
foreground-300 (shade 700 of the scale)
foreground-400 (shade 600 of the scale)
foreground-500 (shade 500 of the scale) <---
foreground-600 (shade 400 of the scale)
foreground-700 (shade 300 of the scale)
foreground-800 (shade 200 of the scale)
foreground-900 (shade 100 of the scale)
foreground-950 (shade 50 of the scale)

This setup causes a contrast issue for shade 500 in dark mode because it remains the same in both modes due to the odd number of shades (11).

Now

// light mode

foreground-50 (shade 50 of the scale)
foreground-100 (shade 100 of the scale)
foreground-200 (shade 200 of the scale)
foreground-300 (shade 300 of the scale)
foreground-400 (shade 400 of the scale)
foreground-500 (shade 500 of the scale) <---
foreground-600 (shade 600 of the scale)
foreground-700 (shade 700 of the scale)
foreground-800 (shade 800 of the scale)
foreground-900 (shade 900 of the scale)

// dark mode (reversed light mode)

foreground-50 (foreground-900 of the scale)
foreground-100 (foreground-800 of the scale)
foreground-200 (foreground-700 of the scale)
foreground-300 (foreground-600 of the scale)
foreground-400 (foreground-500 of the scale)
foreground-500 (foreground-400 of the scale) <---
foreground-600 (foreground-300 of the scale)
foreground-700 (foreground-200 of the scale)
foreground-800 (foreground-100 of the scale)
foreground-900 (foreground-50 of the scale)

This setup makes the shades of the dark color scale lighter, resolving the contrast issue.

What's been done?

• Removed the extra 950 shade from the theme color scales

Checklist

• My code follows the project's coding style and guidelines.
• I have included inline docs for my changes, where applicable.
• I have added, updated or removed tests according to my changes.
• All tests are passing.
• There's an open issue for the PR that I am making.

Additional Notes

Summary by CodeRabbit

• New Features

  • Introduced a method to exclude the last color entry from theme color selections, enhancing the color palette management for both Light and Dark modes.

• Bug Fixes

  • Updated expected counts for theme color properties in unit tests to reflect the new color configuration.

• Chores

  • Updated documentation to specify version 4.0.9 for downloading Tailwind CSS CLI, ensuring compatibility and stability.

[coderabbitai]

Walkthrough

This pull request introduces a new static class DictionaryExtensions with a method TakeAllExceptLast that returns all entries of an input dictionary except for the last specified count. The method includes appropriate error handling and uses LINQ for selection. Additionally, the theme color definitions in SemanticColors.cs now use this method to exclude the final color in each collection, and related tests have been updated: obsolete CSS variable checks were removed and expected color counts were adjusted accordingly.

Changes

File(s)	Change Summary
src/LumexUI/Extensions/DictionaryExtensions.cs	Added new static class with TakeAllExceptLast method performing safe removal of the last N entries from a dictionary.
src/LumexUI/Theme/Colors/SemanticColors.cs	Replaced direct spread operator usage with .TakeAllExceptLast() for color selections in both Light and Dark themes.
tests/LumexUI.Tests/Components/Providers/ThemeProviderTests.cs tests/LumexUI.Tests/Theme/ThemeTests.cs	Removed several CSS variable declarations from tests and updated expected color counts to reflect the modifications in color collections.
docs/LumexUI.Docs/LumexUI.Docs.csproj	Updated URLs for downloading Tailwind CSS CLI to specify version 4.0.9 for Windows and Linux.

Sequence Diagram(s)

sequenceDiagram
    participant Theme as Theme Configuration
    participant Colors as Colors Collection
    participant Ext as DictionaryExtensions

    Theme->>Colors: Retrieve Colors (e.g., Colors.Zinc)
    Colors->>Ext: Invoke .TakeAllExceptLast(count)
    Ext-->>Colors: Return filtered dictionary (without last count entries)
    Colors->>Theme: Apply updated color set to properties

Loading

Possibly related PRs

• feat(docs): add the Theme page #72: The changes in the main PR, which introduce the TakeAllExceptLast method in the DictionaryExtensions class, are directly utilized in the SemanticColors.cs file to modify how theme colors are selected.
• docs(theme): add missing types; improve the 'Usage' section #73: The changes in the main PR, specifically the introduction of the TakeAllExceptLast method in DictionaryExtensions, are directly utilized in the SemanticColors.cs file to modify how color values are selected.
• feat(docs): add the Customize Theme page #116: The changes in the main PR, which introduce the TakeAllExceptLast method in the DictionaryExtensions class, are related to the modifications in the retrieved PR that utilize this method to alter color selections in the SemanticColors.cs file.

Poem

In the coding burrow, I hop and cheer,
A new method brings colors ever so clear.
With a skip of the last, my steps feel light,
Themes refined in day and dark of night.
CodeRabbit Inc leaps with joy in each byte! 🐇

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🔭 Outside diff range comments (1)

tests/LumexUI.Tests/Theme/ThemeTests.cs (1)

17-109: 💡 Verification agent

🧩 Analysis chain

Verify theme consistency with generated colors

While the test count updates are correct, consider adding assertions to explicitly verify that shade 950 is not present in any color scale. This would provide a more robust test that directly validates the PR's objective.

---

🏁 Script executed:

#!/bin/bash
# Check that no 950 shade is present in any color scale

# Look for '950' keys in color definitions
rg -A 5 -B 5 '"950"' src/LumexUI/Theme/

Length of output: 15767

---

Ensure the '950' shade is explicitly excluded from theme color scales

The updated test counts are correct, but the tests do not currently validate that the unintended '950' shade is completely removed. To provide a more robust check aligned with the PR's objective, please add assertions in tests/LumexUI.Tests/Theme/ThemeTests.cs (or the appropriate test file) that iterate through each color scale and assert that the '950' key is not present. For example, after initializing your theme instance, add tests such as:

• theme.Light.Colors.Default.Should().NotContainKey("950");
• theme.Dark.Colors.Default.Should().NotContainKey("950");
• (and similar assertions for other color scales)

This additional validation will directly confirm that the theme generation process filters out the '950' shade as expected.

🧹 Nitpick comments (2)

src/LumexUI/Extensions/DictionaryExtensions.cs (2)

1-27: Clean implementation with a minor error message inconsistency

The implementation of TakeAllExceptLast is well-structured with proper error handling. However, there's a discrepancy in the error message on line 15 - it states "The count must be greater than one" but the check is for count < 1, which means count should be greater than or equal to one.

-			throw new ArgumentOutOfRangeException( nameof( count ), count, "The count must be greater than one." );
+			throw new ArgumentOutOfRangeException( nameof( count ), count, "The count must be greater than or equal to one." );

Also, consider whether this utility method should be excluded from code coverage, as it's an important component now being used throughout the theme system.

---

5-6: Consider making this class public

Since this utility method provides functionality that could be useful throughout the codebase, consider making the class public instead of internal to allow broader reuse.

-internal static class DictionaryExtensions
+public static class DictionaryExtensions

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3708bc2 and cea6b11.

📒 Files selected for processing (4)

• src/LumexUI/Extensions/DictionaryExtensions.cs (1 hunks)
• src/LumexUI/Theme/Colors/SemanticColors.cs (2 hunks)
• tests/LumexUI.Tests/Components/Providers/ThemeProviderTests.cs (0 hunks)
• tests/LumexUI.Tests/Theme/ThemeTests.cs (3 hunks)

💤 Files with no reviewable changes (1)

• tests/LumexUI.Tests/Components/Providers/ThemeProviderTests.cs

🔇 Additional comments (5)

src/LumexUI/Theme/Colors/SemanticColors.cs (3)

5-6: LGTM: Proper import for the new extensions

The import for the LumexUI.Extensions namespace is correctly added to utilize the new TakeAllExceptLast extension method.

---

28-28: Effective implementation of the color scale fix

The use of TakeAllExceptLast() effectively removes the 950 shade from the color scales in the Light theme, addressing the issue of maintaining an even number of shades for proper contrast in dark mode.

Also applies to: 53-53, 58-58, 63-63, 68-68, 73-73, 78-78, 83-83

---

98-98: Consistent application in Dark theme

The same pattern is correctly applied to the Dark theme with ReverseColorValues(Colors.*.TakeAllExceptLast()), ensuring consistent color scale size between themes.

Also applies to: 123-123, 128-128, 133-133, 138-138, 143-143, 148-148, 153-153

tests/LumexUI.Tests/Theme/ThemeTests.cs (2)

20-20: Tests correctly updated for Foreground counts

The expected counts for Foreground colors have been properly adjusted from 12 to 11 to match the removal of the 950 shade.

Also applies to: 36-36

---

55-55: Tests correctly updated for all other color property counts

The expected counts for Default, Primary, Secondary, Success, Warning, Danger, and Info colors in both Light and Dark themes have been properly adjusted from 13 to 12.

Also applies to: 59-59, 63-63, 67-67, 71-71, 75-75, 79-79, 83-83, 87-87, 91-91, 95-95, 99-99, 103-103, 107-107

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

docs/LumexUI.Docs/LumexUI.Docs.csproj (2)

31-32: Explicit Version Pinning for Windows Tailwind CLI
The URL now explicitly points to version v4.0.9 which helps ensure consistent behavior and prevents unexpected breaking changes that might occur if the "latest" release was used.

---

35-36: Explicit Version Pinning for Linux Tailwind CLI
The URL has been updated to reference version v4.0.9, aligning the Linux download with the Windows version. This change improves reproducibility by avoiding potential issues from using a moving target (latest).

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cea6b11 and fa7c18a.

📒 Files selected for processing (1)

• docs/LumexUI.Docs/LumexUI.Docs.csproj (1 hunks)