-
-
Notifications
You must be signed in to change notification settings - Fork 26
fix(select): select value(s) provided in @bind-Value(s) after async initialization
#246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
desmondinho
merged 6 commits into
main
from
fix/select-component-with-default-bind-value
Sep 5, 2025
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
da048fb
refactor(select): rename `IsMultiSelect` flag to `IsMultipleSelect`
desmondinho adda592
refactor(select): rename and move `ItemsCollectedNotifier`
desmondinho 5a2f536
fix(select): ensure default `@bind-Value(s)` marked as selected items
desmondinho 0cf3b38
test(select): add tests
desmondinho 16d9dd2
test(select): adjust test names
desmondinho dba491b
chore(select): suggestions
desmondinho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
57 changes: 0 additions & 57 deletions
57
src/LumexUI/Components/Select/Core/_ItemsCollectedNotifier.cs
This file was deleted.
Oops, something went wrong.
53 changes: 53 additions & 0 deletions
53
src/LumexUI/Components/Select/Internal/ItemsCollectedNotifier.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| // Copyright (c) LumexUI 2024 | ||
| // LumexUI licenses this file to you under the MIT license | ||
| // See the license here https://github.com/LumexUI/lumexui/blob/main/LICENSE | ||
|
|
||
| using System.ComponentModel; | ||
|
|
||
| using Microsoft.AspNetCore.Components; | ||
|
|
||
| using IComponent = Microsoft.AspNetCore.Components.IComponent; | ||
|
|
||
| namespace LumexUI.Internal; | ||
|
|
||
| /// <summary> | ||
| /// For internal use only. | ||
| /// </summary> | ||
| [EditorBrowsable( EditorBrowsableState.Never )] | ||
| public sealed class ItemsCollectedNotifier<TValue> : IComponent | ||
| { | ||
| [CascadingParameter] private SelectContext<TValue> Context { get; set; } = default!; | ||
|
|
||
| private LumexSelect<TValue> Select => Context.Owner; | ||
|
|
||
| private bool _isFirstRender = true; | ||
|
|
||
| void IComponent.Attach( RenderHandle renderHandle ) | ||
| { | ||
| // This component never renders, so we can ignore the renderHandle | ||
| } | ||
|
|
||
| Task IComponent.SetParametersAsync( ParameterView parameters ) | ||
| { | ||
| if( _isFirstRender ) | ||
| { | ||
| parameters.SetParameterProperties( this ); | ||
|
|
||
| if( Context.IsMultipleSelect ) | ||
| { | ||
| Context.UpdateSelectedItems( Select.Values ); | ||
| } | ||
| else | ||
| { | ||
| Context.UpdateSelectedItem( Select.Value ); | ||
| } | ||
|
|
||
| _isFirstRender = false; | ||
| return Task.CompletedTask; | ||
| } | ||
| else | ||
| { | ||
| return Task.CompletedTask; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.