Skip to content

docs(*): add missing component API links #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
desmondinho merged 2 commits into from
Sep 17, 2025
Merged

docs(*): add missing component API links #253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81a5056
fix: added missing API docs links
Denny09310 Sep 17, 2025
cf32396
fix: added tooltip link
Denny09310 Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion docs/LumexUI.Docs.Client/Common/Navigation/NavigationStore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,11 @@ public class NavigationStore
new NavigationCategory( "Components API" )
.Add( new( nameof( LumexAccordion ) ) )
.Add( new( nameof( LumexAccordionItem ) ) )
.Add( new( nameof( LumexAlert ) ) )
Copy link

@coderabbitai coderabbitai bot Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

🧩 Analysis chain

Quick sanity check: components exist and nav isn’t duplicating entries.

Please verify the component types exist and each appears once in the nav.

Also applies to: 61-61, 70-70, 73-73, 80-80, 83-83, 98-98, 99-99

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Check component type definitions exist:"
rg -nP --type=cs -C0 $'\\b(partial\\s+)?class\\s+Lumex(Alert|Badge|Code|Kbd)\\b|\\bclass\\s+Lumex(DataGrid|Radio|RadioGroup)\\s*<' src || true
rg -nP --type=cs -C0 $'\\bclass\\s+LumexDropdownTrigger\\b' src || true

echo
echo "Ensure single nav entry per component:"
targets=(
  'LumexAlert' 'LumexBadge' 'LumexCode' 'LumexDataGrid' 'LumexDropdownTrigger'
  'LumexKbd' 'LumexRadio' 'LumexRadioGroup'
)
for t in "${targets[@]}"; do
  echo -n "$t: "
  rg -n "nameof\\(\\s*${t}(<[^>]*>)?\\s*\\)" docs/LumexUI.Docs.Client/Common/Navigation/NavigationStore.cs | wc -l
done

Length of output: 1251

Duplicate navigation entries in NavigationStore.cs — remove duplicates

Components exist, but docs/LumexUI.Docs.Client/Common/Navigation/NavigationStore.cs contains duplicate nav entries: LumexAlert (2), LumexBadge (2), LumexCode (2), LumexDataGrid (2), LumexKbd (2), LumexRadioGroup (2); LumexDropdownTrigger and LumexRadio appear once. Remove the duplicated Add(new(nameof(...))) calls or dedupe when building the nav (inspect lines ~57, 61, 70, 73, 80, 83, 98, 99).

🤖 Prompt for AI Agents 
In docs/LumexUI.Docs.Client/Common/Navigation/NavigationStore.cs around lines
57, 61, 70, 73, 80, 83, 98–99, the navigation list contains duplicated
Add(new(nameof(...))) entries (LumexAlert, LumexBadge, LumexCode, LumexDataGrid,
LumexKbd, LumexRadioGroup); remove the duplicate Add(...) calls so each
component is added only once or implement a simple dedupe step when building the
nav (e.g., use a HashSet of names before adding or filter the list for distinct
names) to ensure LumexDropdownTrigger and LumexRadio remain single entries and
no duplicates persist.

.Add( new( nameof( LumexAvatar ) ) )
.Add( new( nameof( LumexAvatarGroup ) ) )
//.Add( nameof( LumexBooleanInputBase ) )
.Add( new( nameof( LumexBadge ) ) )
.Add( new( nameof( LumexButton ) ) )
.Add( new( nameof( LumexCard ) ) )
.Add( new( nameof( LumexCardBody ) ) )
Expand All @@ -65,16 +67,20 @@ public class NavigationStore
.Add( new( nameof( LumexCheckbox ) ) )
.Add( new( nameof( LumexCheckboxGroup ) ) )
.Add( new( nameof( LumexChip ) ) )
.Add( new( nameof( LumexCode ) ) )
.Add( new( nameof( LumexCollapse ) ) )
.Add( new( nameof( LumexComponent ) ) )
.Add( new( nameof( LumexDataGrid<T> ) ) )
//.Add( nameof( LumexComponentBase ) )
//.Add( nameof( LumexDebouncedInputBase<T> ) )
.Add( new( nameof( LumexDivider ) ) )
.Add( new( nameof( LumexDropdown ) ) )
.Add( new( nameof( LumexDropdownItem ) ) )
.Add( new( nameof( LumexDropdownMenu ) ) )
.Add( new( nameof( LumexDropdownTrigger ) ) )
//.Add( nameof( LumexInputBase<T> ) )
//.Add( nameof( LumexInputFieldBase<T> ) )
.Add( new( nameof( LumexKbd ) ) )
.Add( new( nameof( LumexLink ) ) )
.Add( new( nameof( LumexListbox<T> ) ) )
.Add( new( nameof( LumexListboxItem<T> ) ) )
Expand All @@ -89,6 +95,8 @@ public class NavigationStore
.Add( new( nameof( LumexPopover ) ) )
.Add( new( nameof( LumexPopoverContent ) ) )
.Add( new( nameof( LumexPopoverTrigger ) ) )
.Add( new( nameof( LumexRadio<T> ) ) )
.Add( new( nameof( LumexRadioGroup<T> ) ) )
.Add( new( nameof( LumexSelect<T> ) ) )
.Add( new( nameof( LumexSelectItem<T> ) ) )
.Add( new( nameof( LumexSkeleton ) ) )
Expand All @@ -97,7 +105,8 @@ public class NavigationStore
.Add( new( nameof( LumexTab ) ) )
.Add( new( nameof( LumexTabs ) ) )
.Add( new( nameof( LumexTextbox ) ) )
.Add( new( nameof( LumexThemeProvider ) ) );
.Add( new( nameof( LumexThemeProvider ) ) )
.Add( new( nameof( LumexTooltip ) ) );

public static Navigation GetNavigation()
{
Expand Down
Loading