implemented spectral response correction and calculate spectral response correction#255
implemented spectral response correction and calculate spectral response correction#255Lulus792 wants to merge 2 commits intoLumiSpy:mainfrom
Conversation
af16b33 to
5c2e11e
Compare
…nse correction, aswell as tests
|
How different is it from the following: import lumispy as lum
import numpy as np
s = lum.signals.LumiSpectrum(np.arange(10))
ref = lum.signals.LumiSpectrum(0.2 * np.ones_like(np.arange(10)))
s = s * refIf there is no difference, and if the https://peps.python.org/pep-0020/ is followed, |
|
from what i know the idea was to implement two functions one for multiplication and the other for division. where for spectral_response_correction you want to remove the reference signal that you get from the measurement instrument which is apperently done via multiplication. And the same exist with division tho i am also not quite sure. Thats at least what i understould tho i would have to ask @jlaehne |
|
i suppose there isnt a difference its i suppose simpöy to be more meanigful? Tho as insaid not entirely sure tho it should be the same as your example |
Indeed, the function should use |
Implemented into CommonLumi the spectral_response_correction aswell as calculate_reponse_correction. Using a helper function _apply which takes an operator besides the ref signal since both function only differ in that functionality. Added tests aswell.
Description of the change
Progress of the PR
upcoming_changesfolder (seeupcoming_changes/README.rst),Minimal example of the bug fix or the new feature