Skip to content

Conversation

@ItsNature
Copy link
Collaborator

@ItsNature ItsNature commented May 5, 2025

Overview

Description:
Introduce a new Glow Module API method that allows overriding the glow effect for a player without explicitly specifying a color. When no color is provided, the glow effect will fall back to the player's scoreboard team color.

Changes:

  • Added GlowModule#overrideGlow(Recipients, UUID) method, supporting scoreboard team color fallback.
  • Updated internal implementation to handle null color values.
  • Updated documentation to reflect fallback behavior.

Code Example:

public void overrideGlowEffectExample(UUID glowingPlayer) {
    this.glowModule.overrideGlow(Recipients.ofEveryone(), glowingPlayer);
}

Review Request Checklist

  • Your code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have tested this change myself. (If applicable)
  • I have made corresponding changes to the documentation. (If applicable)
  • The branch name follows the projects naming conventions. (e.g. feature/add-module & bugfix/fix-issue)

@ItsNature ItsNature added type: Documentation Documentation improvement or issue type: Enhancement Feature improvement or addition labels May 5, 2025
@ItsNature ItsNature merged commit ce85264 into version/1.1.9 May 12, 2025
2 checks passed
@ItsNature ItsNature deleted the improvement/glow-module-scoreborard-color-fallback branch May 12, 2025 23:35
@ItsNature ItsNature mentioned this pull request May 12, 2025
ItsNature added a commit that referenced this pull request Sep 3, 2025
* Deploy as 1.1.9-SNAPSHOT

* Glow Module - Add Scoreborard Team Color Fallback (#209)

* Add documentation & API method for scoreboard color fallback

* Add info callout for scoreboard team color

* chore: update to new Maven repo (#212)

* chore: update to new Maven repo

* fix: use specific proto version

* docs: update apollo-protos versions

---------

Co-authored-by: ItsNature <[email protected]>

* Update summon command examples (#211)

* Improvement - Include the packet sender in Packet Enrichment Events (#220)

* Add sender to Packet Enrichment events

* Add the sender field to the event documentation

* Title Module - Add a option to clear the title on server switch (#223)

* Add `CLEAR_TITLE_ON_SERVER_SWITCH` option to the Title Module

* Add example docs

* Add `clearOnServerSwitch` parameter to the Title example command

* Update format

* Add documentation & code example for new inventory module tags (#217)

* Sync LunarClient Mods & Options (#226)

* Sync LunarClient Mods & Options

* Update version tags to 1.1.9

---------

Co-authored-by: LunarClient Bot <[email protected]>

* Delete deploy script (#224)

* example: restructure gradle modules (#228)

* Feature - User Metadata (#225)

* Bukkit and bungee impl

* finish bungee impl

* Velocity & Folia impl

* Remove debug

* fix brand collecting on bukkit & bungee

* Bump to 1.1.9 (#227)

---------

Co-authored-by: Colin McDonald <[email protected]>
Co-authored-by: LunarClient Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: Documentation Documentation improvement or issue type: Enhancement Feature improvement or addition

Development

Successfully merging this pull request may close these issues.

4 participants