Skip to content

Conversation

@FxMorin
Copy link
Member

@FxMorin FxMorin commented Oct 18, 2025

Overview

Description:
EnumOption is the only option type that doesn't have a static builder method defined in Option.
This PR adds the missing method.

Changes:
Added the missing enum option builder in Option

Code Example (If applicable):

EnumOption<SomeEnum> enumOption = Option.<SomeEnum>enumerator()
        .node("example", "option-id").type(TypeToken.get(SomeEnum.class))
        .notifyClient()
        .build();

Related Issue (If applicable):

Screenshots and/or Videos (If applicable):


Review Request Checklist

  • Your code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have tested this change myself. (If applicable)
  • I have made corresponding changes to the documentation. (If applicable)
  • The branch name follows the projects naming conventions. (e.g. feature/add-module & bugfix/fix-issue)

- Like the other option types
@ItsNature ItsNature force-pushed the feature/enum-builder branch from 823b175 to 8f0caf4 Compare October 18, 2025 01:26
@ItsNature ItsNature changed the base branch from master to version/1.2.1 October 18, 2025 01:26
@ItsNature ItsNature merged commit 8692b55 into version/1.2.1 Oct 18, 2025
2 checks passed
@ItsNature ItsNature deleted the feature/enum-builder branch October 18, 2025 01:32
@ItsNature ItsNature mentioned this pull request Oct 23, 2025
ItsNature added a commit that referenced this pull request Dec 16, 2025
* Deploy as 1.2.1-SNAPSHOT

* Restructure platform modules (#236)

* add a parent platform gradle module

* add readme banner

* Add a few gh badges

* remove build tools

---------

Co-authored-by: Trentin <[email protected]>

* Bump bungee to 1.21-R0.4 (#240)

* Option: Add static enum builder method (#239)

- Like the other option types

* Sync LunarClient Mods & Options (#241)

* Sync LunarClient Mods & Options

* Update version tags to 1.2.1

---------

Co-authored-by: LunarClient Bot <[email protected]>

* Feature - Mod Status API (#243)

* Apollo Mod Status API

* Remove mod options loading logic from auto gen

* example: add mod status command

* Receive mod status from the handshake packet

* don't use WeakHashMap for options

* Markdown docs

* Fix hyperlinks

* Move mod status API into ModSettingsModule

* Option API improvements

* Remove debug

* add mod settings module tests

* Make global options protected

* Link mod available options in the mod status example

* example: remove debug

* Prepare for merge

* Feature - PayNow Module (#244)

* Add the pay now module

# Conflicts:
#	common/src/main/java/com/lunarclient/apollo/player/ApolloPlayerManagerImpl.java
#	docs/developers/lightweight/protobuf/getting-started.mdx
#	gradle/libs.versions.toml

* Fix import order

* Update example message

* Paynow docs

* Dont deploy this branch

* Bump to 1.2.1 (#245)

---------

Co-authored-by: Trentin <[email protected]>
Co-authored-by: Fx Morin <[email protected]>
Co-authored-by: LunarClient Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants