fix broken --version option#12
Open
ChanceHarrison wants to merge 1 commit intoLunarEclipse363:mainfrom
Open
Conversation
since the binary is named brother_ql but the distribution name is brother_ql_next, the package_name argument needs to be specified for it to work correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the binary is named
brother_qlbut the distribution name isbrother_ql_next, click'sversion_optionfunction isn't able to detect the version by default. This is resolved by specifying thepackage_nameargument to said function.This remedies some of the odd behavior seen in #11