chore(text editor): bump prosemirror-model to 1.22.1 #3300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3300/ |
adrianschmidt
previously approved these changes
Nov 14, 2024
Contributor
adrianschmidt
left a comment
adrianschmidt
left a comment
There was a problem hiding this comment.
Seems reasonable.
I just did a very quick smoke test, making sure it was possible to write stuff in the basic example, and that we got the updated value output.
adrianschmidt
requested changes
Nov 14, 2024
Contributor
adrianschmidt
left a comment
adrianschmidt
left a comment
There was a problem hiding this comment.
This should be a fix, so it creates a new release, and it's good if the commit message says what the benefit to the consumer is. Something like:
fix(text-editor): update prosemirror-model to 1.22.1 to fix XSS vulnerability
john-traas
force-pushed
the
bump-prosemirror-model-version
branch
from
7f57618 to
a1cccc2
Compare
Contributor
Author
⚡ Updated |
adrianschmidt
approved these changes
Nov 14, 2024
Collaborator
|
🎉 This PR is included in version 37.66.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per this post here we should update to prosemirror-model 1.22.1 as it contains a fix for a vulnerability to xss attacks in the DOMSerialiser.