fix(text-editor): make sure trigger characters work on Android #3307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3307/ |
john-traas
approved these changes
Nov 20, 2024
Contributor
john-traas
left a comment
john-traas
left a comment
There was a problem hiding this comment.
It looks good to me but I can't test it on an android device.
Contributor
Author
I've tested it via BrowserStack and just now on my own phone. Interestingly, when I switch it over to using chip, deleting the chip is a little wonky. If I write text both before and after it, and then delete the text from the end of the line, the chip isn't deleted until all the text has been deleted. Something to look into possibly. But we can merge this regardless 😄 |
Collaborator
|
🎉 This PR is included in version 37.69.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Lundalogik/crm-feature#4470
Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: