Skip to content

Conversation

@Kiarokh
Copy link
Contributor

@Kiarokh Kiarokh commented Nov 20, 2024

Review:

  • Commits are atomic
  • Commits have the correct type for the changes made
  • Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

  • Chrome
  • Edge
  • Firefox

Linux:

  • Chrome
  • Firefox

macOS:

  • Chrome
  • Firefox
  • Safari

Mobile:

  • Chrome on Android
  • iOS

@Kiarokh Kiarokh added the feature New feature or request label Nov 20, 2024
@Kiarokh Kiarokh self-assigned this Nov 20, 2024
@github-actions
Copy link

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3308/

jgroth
jgroth previously approved these changes Nov 20, 2024
Copy link
Contributor

@jgroth jgroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interfaces approved!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fixing the errors…

}

return (
<limel-action-bar
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must say that I'm not super happy about using limel-action-bar for rendering actions, as in most scenarios in card components, there is a "Primary" action, and actions are more highlighted.

  1. We don't have a way to make one of the actions primary in the action bar.
  2. The primary action is always at the right side, however, it might be so that it ends up in the overflow menu, when the card becomes too small. That also, I don't know how to handle yet.

These are not easy to fix, without overcomplicating the APIs of limel-action-bar.

But I think for now, this can work. For future, we should probably make a custom actions sections inside the limel-card, instead.

const image = {
src: 'https://images.unsplash.com/photo-1494232410401-ad00d5433cfa?q=80&w=2670&auto=format&fit=crop&ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D',
alt: 'A picture of an old cassette tape',
loading: 'lazy' as 'lazy',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeezus typescript… 🙈 🙄

I hope not too much of your soul had to die before you found this solution? ❤️‍🩹🫂

@Kiarokh Kiarokh merged commit 8a9e5ee into main Nov 20, 2024
10 checks passed
@Kiarokh Kiarokh deleted the card branch November 20, 2024 16:01
@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.69.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants