-
Notifications
You must be signed in to change notification settings - Fork 16
feat(card): add new component #3308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3308/ |
jgroth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interfaces approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fixing the errors…
| } | ||
|
|
||
| return ( | ||
| <limel-action-bar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must say that I'm not super happy about using limel-action-bar for rendering actions, as in most scenarios in card components, there is a "Primary" action, and actions are more highlighted.
- We don't have a way to make one of the actions primary in the action bar.
- The primary action is always at the right side, however, it might be so that it ends up in the overflow menu, when the card becomes too small. That also, I don't know how to handle yet.
These are not easy to fix, without overcomplicating the APIs of limel-action-bar.
But I think for now, this can work. For future, we should probably make a custom actions sections inside the limel-card, instead.
| const image = { | ||
| src: 'https://images.unsplash.com/photo-1494232410401-ad00d5433cfa?q=80&w=2670&auto=format&fit=crop&ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D', | ||
| alt: 'A picture of an old cassette tape', | ||
| loading: 'lazy' as 'lazy', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jeezus typescript… 🙈 🙄
I hope not too much of your soul had to die before you found this solution? ❤️🩹🫂
|
🎉 This PR is included in version 37.69.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: