Skip to content

Text Editor: trailing * is added to label even if required=false#3391

Merged
TommyLindh2 merged 1 commit intomainfrom
fix/3390-text-editor-required-label
Jan 9, 2025
Merged

Text Editor: trailing * is added to label even if required=false#3391
TommyLindh2 merged 1 commit intomainfrom
fix/3390-text-editor-required-label

Conversation

@TommyLindh2
Copy link
Contributor

Fixes #3390

Before fix
Required image
Non-required image
After fix
Required image
Non-required image

Review:

  • Commits are atomic
  • Commits have the correct type for the changes made
  • Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

  • Chrome
  • Edge
  • Firefox

Linux:

  • Chrome
  • Firefox

macOS:

  • Chrome
  • Firefox
  • Safari

Mobile:

  • Chrome on Android
  • iOS

@TommyLindh2 TommyLindh2 requested review from Kiarokh and removed request for Kiarokh January 8, 2025 07:13
@github-actions
Copy link

github-actions bot commented Jan 8, 2025

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3391/

@TommyLindh2 TommyLindh2 changed the title fix(text-editor): don't show trailing * when required="false" Text Editor: trailing * is added to label even if required=false #3390 Jan 8, 2025
@TommyLindh2 TommyLindh2 changed the title Text Editor: trailing * is added to label even if required=false #3390 Text Editor: trailing * is added to label even if required=false Jan 8, 2025
Copy link
Contributor

@LucyChyzhova LucyChyzhova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! 💫

@LucyChyzhova
Copy link
Contributor

Just test is failed

@adrianschmidt adrianschmidt force-pushed the fix/3390-text-editor-required-label branch from 97f8ac4 to 357c2d6 Compare January 8, 2025 17:03
@TommyLindh2 TommyLindh2 force-pushed the fix/3390-text-editor-required-label branch from 357c2d6 to fa764f3 Compare January 9, 2025 06:22
@TommyLindh2 TommyLindh2 merged commit e2b7118 into main Jan 9, 2025
12 checks passed
@TommyLindh2 TommyLindh2 deleted the fix/3390-text-editor-required-label branch January 9, 2025 06:32
@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.78.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text Editor: trailing * is added to label even if required=false

3 participants

Comments