add support for displaying pictures in the list items#3392
Conversation
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3392/ |
Befkadu1
force-pushed
the
show-pics-list-item
branch
from
6996f0c to
a70b05c
Compare
Befkadu1
force-pushed
the
show-pics-list-item
branch
from
a70b05c to
d7f4aca
Compare
| icon?: string | Icon; | ||
| // @deprecated | ||
| iconColor?: string; | ||
| image?: Image_2; |
There was a problem hiding this comment.
i know this is auto generated, but it just felt weird that it says Image_2. Did we do something wrong, or is this correct?
There was a problem hiding this comment.
No idea it is auto generated running the command npm run api:update
There was a problem hiding this comment.
I don't know. I'm not sure if I've seen that in this file before. I know I've seen it somewhere, but I'm fairly sure that's been in components.d.ts. In this case, I find Image_2 referenced in dist/lime-elements.d.ts, but I can't seem to find where it's actually coming from.
I've tried removing the existing dist folder and other temporary folders, and run the build and api:update script again, but just got the same result anyway.
It's exported as Image anyway, so it shouldn't be a problem:
adrianschmidt
left a comment
adrianschmidt
left a comment
There was a problem hiding this comment.
Changes to external interface approved 👍
|
🎉 This PR is included in version 37.79.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: