Skip to content

fix(card): make the UI more responsive#3405

Merged
LucyChyzhova merged 1 commit intomainfrom
more-responsive-card
Jan 17, 2025
Merged

fix(card): make the UI more responsive#3405
LucyChyzhova merged 1 commit intomainfrom
more-responsive-card

Conversation

@Kiarokh
Copy link
Contributor

@Kiarokh Kiarokh commented Jan 17, 2025

There is a good chance that the value which will be rendered in markdown is very large.
In such cases, the consumer may limit the height or max-height of the component, which will result in the content to overflow out of the card.
The component should have a more responsive UI
when its size is more limited by the consumer.

fix #3404

Review:

  • Commits are atomic
  • Commits have the correct type for the changes made
  • Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

  • Chrome
  • Edge
  • Firefox

Linux:

  • Chrome
  • Firefox

macOS:

  • Chrome
  • Firefox
  • Safari

Mobile:

  • Chrome on Android
  • iOS

There is a good chance that the `value` which will
be rendered in markdown is very large.
In such cases, the consumer may limit the `height` or
`max-height` of the component, which will result in
the content to overflow out of the card.
The component should have a more responsive UI
when its size is more limited by the consumer.
@github-actions
Copy link

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3405/

Copy link
Contributor

@LucyChyzhova LucyChyzhova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 💫 ✨

@LucyChyzhova LucyChyzhova merged commit bc2a007 into main Jan 17, 2025
12 checks passed
@LucyChyzhova LucyChyzhova deleted the more-responsive-card branch January 17, 2025 13:37
@lime-opensource
Copy link
Collaborator

🎉 This PR is included in version 37.79.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

card: body text overflows out of a card with fixed a height

3 participants

Comments