-
Notifications
You must be signed in to change notification settings - Fork 16
Remove @beta JSDoc tags from some components
#3627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis change removes all Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the @beta annotation from several components and properties, indicating they are being promoted from beta status to stable/production ready. This appears to be a stabilization effort for various UI components and their associated properties.
- Remove
@betaannotations from multiple component classes and properties - Update CSS styling for checkbox component (margin adjustment)
- Promote Label interface and related functionality from beta to stable
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/switch/switch.tsx | Remove @beta from readonlyLabels property |
| src/components/dynamic-label/label.types.ts | Remove @beta from Label interface |
| src/components/dynamic-label/dynamic-label.tsx | Remove @beta from DynamicLabel component |
| src/components/chip/chip.tsx | Remove @beta from type property |
| src/components/checkbox/checkbox.tsx | Remove @beta from readonlyLabels property |
| src/components/checkbox/checkbox.scss | Remove left margin from limel-dynamic-label |
| src/components/card/card.tsx | Remove @beta from Card component |
Comments suppressed due to low confidence (1)
src/components/checkbox/checkbox.scss:25
- The removal of margin-left styling appears unrelated to the main purpose of this PR (removing @beta annotations). This change should either be documented in the PR description or moved to a separate commit to maintain atomic commits.
margin-top: 0.375rem;
|
|
||
| limel-dynamic-label { | ||
| margin-top: 0.375rem; | ||
| margin-left: 0.25rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3627/ |
@beta JSDoc tags from some components
The component has been thoroughly tested for a while and its API is stable. Removing the `@beta` tag to mark it as production-ready.
The component has been thoroughly tested for a while and its API is stable. Removing the `@beta` tag to mark it as production-ready.
The `type` prop of the component has been thoroughly tested for a while and is stable. Removing the `@beta` tag to mark it as production-ready.
|
🎉 This PR is included in version 38.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |

Summary by CodeRabbit
@betatags from various components and properties.Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: