Skip to content

Replace hardcoded small font sizes with theme variable in SCSS files #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucyChyzhova merged 2 commits into from
Aug 6, 2025
Merged

Replace hardcoded small font sizes with theme variable in SCSS files #3635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fd159f
chore(components): add a centralized internal variable for all small …
Kiarokh Aug 6, 2025
5082625
chore(components): use a centralized internal variable for all small …
Kiarokh Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/button-group/button-group.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
}

.mdc-chip__text {
font-size: functions.pxToRem(13);
font-size: var(--limel-theme-default-small-font-size);
overflow: hidden;
text-overflow: ellipsis;
display: block;
Expand Down
4 changes: 3 additions & 1 deletion src/components/dynamic-label/dynamic-label.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ limel-icon {

label {
flex-grow: 1;
font-size: 0.8125rem; // `13px`, Like Checkbox & Switch
font-size: var(
--limel-theme-default-small-font-size
); // `13px`, Like Checkbox & Switch
line-height: normal;
color: var(--limel-theme-on-surface-color);
padding-top: 0.375rem;
Expand Down
2 changes: 1 addition & 1 deletion src/components/form/row/row.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
.description {
margin: 0;
color: var(--limel-theme-text-secondary-on-background-color);
font-size: 0.8125rem;
font-size: var(--limel-theme-default-small-font-size);
line-height: 1.5;
}

Expand Down
2 changes: 1 addition & 1 deletion src/components/header/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@

.subheading {
color: var(--header-subheading-color, rgb(var(--contrast-900)));
font-size: functions.pxToRem(13);
font-size: var(--limel-theme-default-small-font-size);
font-weight: 400;
}

Expand Down
4 changes: 2 additions & 2 deletions src/components/list/list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ $list-mdc-list-item: 0;

.mdc-deprecated-list-item__secondary-text {
opacity: 0.6;
font-size: 0.8125rem; //13px
font-size: var(--limel-theme-default-small-font-size); //13px
}

.mdc-deprecated-list-item--disabled {
Expand Down Expand Up @@ -97,7 +97,7 @@ $list-mdc-list-item: 0;
all: unset;
@include mixins.truncate-text;
color: rgb(var(--contrast-900));
font-size: 0.8125rem; // 13px
font-size: var(--limel-theme-default-small-font-size); // 13px
}

.mdc-deprecated-list-item {
Expand Down
2 changes: 1 addition & 1 deletion src/components/markdown/partial-styles/_pre-code.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

code {
@include mixins.font-family(monospace);
font-size: functions.pxToRem(13);
font-size: var(--limel-theme-default-small-font-size);
letter-spacing: functions.pxToRem(-0.2);
color: rgb(var(--contrast-1300));

Expand Down
2 changes: 1 addition & 1 deletion src/components/menu-list/menu-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
margin: functions.pxToRem(4);
// added space to visualize keyboard-focused items
.mdc-deprecated-list-item[role='menuitem'] {
font-size: functions.pxToRem(13);
font-size: var(--limel-theme-default-small-font-size);

.mdc-deprecated-list-item__graphic {
margin-right: 0;
Expand Down
2 changes: 1 addition & 1 deletion src/components/slider/slider.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ div[slot='content'] {
}

.mdc-slider__value-indicator-text {
font-size: 0.8125rem; //13px
font-size: var(--limel-theme-default-small-font-size); //13px
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/components/snackbar/snackbar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ aside {
color: rgb(var(--contrast-100));

-webkit-font-smoothing: antialiased;
font-size: 0.8125rem;
font-size: var(--limel-theme-default-small-font-size);
font-weight: 400;
padding: 0 0.25rem;

Expand Down
1 change: 1 addition & 0 deletions src/global/core-styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

// The default font size for Lime Elements components.
--limel-theme-default-font-size: 0.875rem; //14px
--limel-theme-default-small-font-size: 0.8125rem; //13px
}

// ⚠️ This section below is commented out.
Expand Down