-
Notifications
You must be signed in to change notification settings - Fork 16
chore(sync packages): ensure react and react-dom remain in sync #3645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughAdded a React update group to Dependabot, introduced a GitHub Actions job to verify React and React-DOM versions match and made automerge depend on it, and relaxed React/React-DOM devDependency pins in package.json from exact to caret ranges. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer/PR
participant GH as GitHub Actions
participant Check as check-react-versions
participant Other as lint/build/test/docs/autosquash
participant Auto as automerge
Dev->>GH: Open/Update PR
GH->>Check: Run version consistency check
GH->>Other: Run other jobs
Check-->>GH: Pass/Fail
Other-->>GH: Pass/Fail
GH->>Auto: Proceed if all needs pass
Auto-->>Dev: Auto-merge PR (if eligible)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements synchronization between React and React-DOM packages to prevent version mismatches during dependency updates. It ensures that dependabot updates both packages together and adds automated validation to catch any version discrepancies.
- Switches React and React-DOM from exact versions to caret ranges for better dependency management
- Adds a GitHub Actions workflow job to validate React and React-DOM versions match
- Configures dependabot to group React packages together for synchronized updates
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates React and React-DOM to use caret version ranges instead of exact versions |
| .github/workflows/pr-checks.yml | Adds validation job to ensure React and React-DOM versions match |
| .github/dependabot.yml | Configures React package grouping for synchronized dependabot updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3645/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
.github/dependabot.yml(1 hunks).github/workflows/pr-checks.yml(1 hunks)package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Docs / Publish Docs
- GitHub Check: Build
- GitHub Check: Test
🔇 Additional comments (2)
package.json (1)
78-79: LGTM: loosened React/React-DOM ranges align with the sync check and update grouping.Using caret ranges for both ensures minor/patch updates can roll together while the workflow enforces version parity.
.github/workflows/pr-checks.yml (1)
90-90: LGTM: automerge now depends on the React version sync check.This enforces version parity before Dependabot PRs auto-merge.
cd14604 to
9154442
Compare
b112a76 to
1e1afc3
Compare
|
🎉 This PR is included in version 38.22.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Add react and react-dom to a group to ensure dependabot updates them both in the same PR.
Adds a PR sync to ensure versions stay in sync.
Summary by CodeRabbit