-
Notifications
You must be signed in to change notification settings - Fork 16
Update some dependencies to address an npm audit warning #3657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughUpdates ESLint tooling: adds a rule override in eslint.config.mjs and bumps devDependencies (@limetech/eslint-config to ^4.0.0, eslint to ^9.34.0) in package.json. No runtime or public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3657/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
eslint.config.mjs(1 hunks)package.json(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Docs / Publish Docs
- GitHub Check: Build
- GitHub Check: Test
🔇 Additional comments (1)
package.json (1)
40-40: Bump @limetech/eslint-config → v4.0.0: peers satisfied, but audit warnings remain
Peer dependencies
@limetech/[email protected]only requireseslint >= 9; you’re on[email protected]andnpm lsshows no unmet peers.- It brings in
@typescript-eslint/[email protected],@typescript-eslint/[email protected]and[email protected]with no version conflicts. You may still want to confirm that TS 4.9.5 is fully supported by TS-ESLint v8.40.Audit status
- After installing,
npm auditreports 12 vulnerabilities (2 moderate, 10 high), including:
• jsonpointer (Prototype Pollution)
• marked (Inefficient RegExp)
• tar-fs (Path Traversal)
• trim (ReDoS)
• ws (DoS)- These stem from dev-only packages (
@rjsf/core,typedoc/kompendium,puppeteer/puppeteer-core).Next steps
- Decide whether to run
npm audit fix(with--force) now and absorb any breaking bumps, or schedule a follow-up PR to update those dev dependencies.
|
🎉 This PR is included in version 38.22.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary by CodeRabbit
Chores
Style
No user-facing changes.