Skip to content

fix(slider): add accessible description context #3667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kiarokh merged 4 commits into from
Sep 3, 2025
Merged

fix(slider): add accessible description context #3667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21a6c2b
fix(slider): add accessible description context
paulinewahle Sep 2, 2025
333eea5
fix(checkbox): ensure `aria-controls` references an existing element
Kiarokh Sep 3, 2025
903a688
fix(switch): ensure `aria-controls` references an existing element
Kiarokh Sep 3, 2025
93af698
fix(text-editor): ensure `aria-controls` references an existing element
Kiarokh Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/checkbox/checkbox.template.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ export const CheckboxTemplate: FunctionalComponent<CheckboxTemplateProps> = (
return [
<limel-dynamic-label
value={props.checked}
aria-controls={props.helperTextId}
aria-controls={
props.helperText ? props.helperTextId : undefined
}
defaultLabel={{ text: props.label, icon: icon }}
labels={props.readonlyLabels}
/>,
Expand Down Expand Up @@ -75,7 +77,9 @@ export const CheckboxTemplate: FunctionalComponent<CheckboxTemplateProps> = (
disabled={props.disabled || props.readonly}
required={props.required}
onChange={props.onChange}
aria-controls={props.helperTextId}
aria-controls={
props.helperText ? props.helperTextId : undefined
}
aria-describedby={props.helperTextId}
{...inputProps}
/>
Expand Down
5 changes: 4 additions & 1 deletion src/components/slider/slider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,10 @@ export class Slider {
value={this.multiplyByFactor(this.value)}
name="volume"
aria-labelledby={this.labelId}
aria-controls={this.helperTextId}
aria-describedby={
this.helperText ? this.helperTextId : undefined
}
aria-controls={this.helperText ? this.helperTextId : undefined}
{...inputProps}
/>
);
Expand Down
6 changes: 4 additions & 2 deletions src/components/switch/switch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,9 @@ export class Switch {
return [
<limel-dynamic-label
value={this.value}
aria-controls={this.helperTextId}
aria-controls={
this.helperText ? this.helperTextId : undefined
}
defaultLabel={{ text: this.label, icon: icon }}
labels={this.readonlyLabels}
/>,
Expand All @@ -166,7 +168,7 @@ export class Switch {
aria-checked={this.value}
disabled={this.disabled}
onClick={this.handleClick}
aria-controls={this.helperTextId}
aria-controls={this.helperText ? this.helperTextId : undefined}
>
<div class="mdc-switch__track" />
<div class="mdc-switch__handle-track">
Expand Down
6 changes: 4 additions & 2 deletions src/components/text-editor/text-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,9 @@ export class TextEditor implements FormComponent<string> {
<limel-markdown
slot="content"
value={this.value}
aria-controls={this.helperTextId}
aria-controls={
this.helperText ? this.helperTextId : undefined
}
id={this.editorId}
/>
);
Expand All @@ -284,7 +286,7 @@ export class TextEditor implements FormComponent<string> {
onMetadataChange={this.handleMetadataChange}
customElements={this.customElements}
value={this.value}
aria-controls={this.helperTextId}
aria-controls={this.helperText ? this.helperTextId : undefined}
id={this.editorId}
aria-disabled={this.disabled}
aria-invalid={this.invalid}
Expand Down