Skip to content

fix(radio-button-group): use internal import path for types #3695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kiarokh merged 1 commit into from
Oct 3, 2025
Merged

fix(radio-button-group): use internal import path for types #3695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/radio-button-group/radio-button-group.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Component, Event, EventEmitter, h, Prop } from '@stencil/core';
import { ListItem, ListSeparator } from '../list-item/list-item.types';
import { LimelListCustomEvent } from '@limetech/lime-elements';
import { LimelListCustomEvent } from '../../components';
Copy link

@coderabbitai coderabbitai bot Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

LGTM! Import path correctly updated to use relative path.

The change from @limetech/lime-elements to ../../components aligns with the coding guidelines, which require relative paths for same-module imports to avoid circular dependencies and build failures.

As per coding guidelines, verify that the import path resolves correctly:

🏁 Script executed:

#!/bin/bash
# Description: Verify that LimelListCustomEvent is exported from ../../components (src/components/index.ts or similar)

# Find the barrel export file
fd -t f "index.ts" src/components -d 1 --exec cat {} \; | rg -n "LimelListCustomEvent"

# Also check if there's a components.ts or components.d.ts
fd -t f -g "components.*" src -d 1 --exec sh -c 'echo "=== {} ===" && cat {}'

Length of output: 0

🏁 Script executed:

#!/bin/bash
echo "=== Searching for LimelListCustomEvent occurrences in src/components ==="
rg -n "LimelListCustomEvent" src/components || echo "No occurrences found"
echo ""
echo "=== Listing index.ts files under src/components ==="
fd -t f index.ts src/components || echo "No index.ts files found"
echo ""
echo "=== Checking barrel exports in index.ts files ==="
fd -t f index.ts src/components -x sh -c 'echo "== File: {} =="; grep -n "export .*LimelListCustomEvent" {} || echo "No exports in {}"'

Length of output: 2533

Fix import path for LimelListCustomEvent
../../components has no barrel export for this type. Import it directly from its definition (for example, ../list/list.types) or add LimelListCustomEvent to your src/components/index.ts barrel.

🤖 Prompt for AI Agents 
In src/components/radio-button-group/radio-button-group.tsx around line 3, the
import for LimelListCustomEvent is pointing to a barrel that doesn’t export that
type; change the import to the type’s actual file (e.g., import {
LimelListCustomEvent } from '../list/list.types') or alternatively add
LimelListCustomEvent to src/components/index.ts so the barrel export is
available.


/**
* The Radio Button component provides a convenient way to create a group of radio buttons
Expand Down