chore(markdown): add a private helper class to reset hardcoded height on img tags#3712
chore(markdown): add a private helper class to reset hardcoded height on img tags#3712
img tags#3712Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughA CSS host rule is added to the Markdown component stylesheet that resets image heights to auto within the internal markdown container, addressing cases where content may include fixed heights from external sources like Word documents or emails. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
src/components/markdown/markdown.scss(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
src/components/**/*.scss
📄 CodeRabbit inference engine (.cursor/rules/css-class-names-in-components-using-shadow-dom.mdc)
Do not use BEM-style class names in CSS for components, as components use shadow-DOM.
Files:
src/components/markdown/markdown.scss
**/*.{tsx,scss}
⚙️ CodeRabbit configuration file
**/*.{tsx,scss}: Almost all our components use shadow-DOM. Therefore, we have no need of BEM-style class names in our CSS.
Files:
src/components/markdown/markdown.scss
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Docs / Publish Docs
- GitHub Check: Test
- GitHub Check: Build
🔇 Additional comments (1)
src/components/markdown/markdown.scss (1)
37-47: Well-implemented helper class using proper shadow-DOM selectors.The implementation correctly uses the
:host()functional pseudo-class to scope the rule to the component instance when thereset-img-heightclass is applied. This approach aligns with shadow-DOM best practices and the coding guideline to avoid BEM-style class names. The rule is appropriately documented as internal-only, and the targeted reset of image heights toautois a minimal, non-invasive change that addresses the documented issue with fixed-height images from external sources (Word, emails).
e0368d7 to
7c3174e
Compare
|
🎉 This PR is included in version 38.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fix https://github.com/Lundalogik/crm-client/issues/409
fix https://github.com/Lundalogik/limepkg-email/issues/1745
Summary by CodeRabbit
Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: