Fixed invalid function on to_deal_todo in Lime Easy source runner.rb#80
Open
DonHassanOjner wants to merge 1 commit intomasterfrom
Open
Fixed invalid function on to_deal_todo in Lime Easy source runner.rb#80DonHassanOjner wants to merge 1 commit intomasterfrom
DonHassanOjner wants to merge 1 commit intomasterfrom
Conversation
…izations.
The function find_person_by_integration_id on a rootmodel object could be used.
As well an organization must exist on the todo.
Contributor
|
There is a method find_employee_by_integration_id on organization, I think the problem is that the old code will fail if todo.organization is nil. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the function find_employee_by_integration_id that does not exist on organizations.
Used the function find_person_by_integration_id on the rootmodel object instead.
Added an additional check that the todo has a connected organization.