Skip to content

Remove test dealing with removed demo data#628

Closed
MookLags wants to merge 1 commit intoLuteOrg:developfrom
MookLags:develop
Closed

Remove test dealing with removed demo data#628
MookLags wants to merge 1 commit intoLuteOrg:developfrom
MookLags:develop

Conversation

@MookLags
Copy link

@MookLags MookLags commented Aug 5, 2025

I noticed this TODO under a test that loaded demo data which was I think was removed in Issue 534. It looks like it's unused. I figured that it was small enough that I didn't need to do an issue. Is that alright?

Copy link
Collaborator

@jzohrab jzohrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this can be removed, as the "Given demo data" is referenced in one of the feature files:

cat ./features/rendering.feature
Feature: Rendering
    Text is rendered correctly.

    Background:
        Given demo data

If you can confirm that this "@given" can be removed without breaking the acceptance tests, then we should be fine, but I'm reluctant to merge it.

(I should remove the TODO, I'm not even sure why it's there!)

@jzohrab
Copy link
Collaborator

jzohrab commented Aug 16, 2025

Thanks @MookLags for submitting, this breaks tests :-) e.g.

FAILED tests/features/test_rendering.py::test_rendering_smoke_test - pytest_bdd.exceptions.StepDefinitionNotFoundError: Step definition is not found: Given "demo data". Line 5 in scenario "Rendering smoke test" in the feature "/home/runner/work/lute-v3/lute-v3/tests/features/rendering.feature"

Note this isn't a test, it's a step definition used by the feature files.

I'm not sure why the TODO is there .... blah, should have left a better comment, because I would have had a reason as to why something needed to be removed or changed.

@jzohrab
Copy link
Collaborator

jzohrab commented Aug 16, 2025

Closing PR, breaks tests. Unfortunately that TODO is still there ... and I can't recall why. :-/

@jzohrab jzohrab closed this Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants