Remove test dealing with removed demo data#628
Closed
MookLags wants to merge 1 commit intoLuteOrg:developfrom
Closed
Remove test dealing with removed demo data#628MookLags wants to merge 1 commit intoLuteOrg:developfrom
MookLags wants to merge 1 commit intoLuteOrg:developfrom
Conversation
jzohrab
requested changes
Aug 16, 2025
Collaborator
jzohrab
left a comment
There was a problem hiding this comment.
I don't believe this can be removed, as the "Given demo data" is referenced in one of the feature files:
cat ./features/rendering.feature
Feature: Rendering
Text is rendered correctly.
Background:
Given demo data
If you can confirm that this "@given" can be removed without breaking the acceptance tests, then we should be fine, but I'm reluctant to merge it.
(I should remove the TODO, I'm not even sure why it's there!)
Collaborator
|
Thanks @MookLags for submitting, this breaks tests :-) e.g. Note this isn't a test, it's a step definition used by the feature files. I'm not sure why the TODO is there .... blah, should have left a better comment, because I would have had a reason as to why something needed to be removed or changed. |
Collaborator
|
Closing PR, breaks tests. Unfortunately that TODO is still there ... and I can't recall why. :-/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this TODO under a test that loaded demo data which was I think was removed in Issue 534. It looks like it's unused. I figured that it was small enough that I didn't need to do an issue. Is that alright?