Skip to content

[Fix] Tibetan renders properly #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tomer-gom wants to merge 1,671 commits into from
Closed

[Fix] Tibetan renders properly #645

tomer-gom wants to merge 1,671 commits into from

Conversation

@tomer-gom
Copy link

@tomer-gom tomer-gom commented Dec 5, 2025 •
edited
Loading

Summary

Currently Tibetan isn't rendered properly, characters aren't stacking as they are supposed to. This is because the font used doesn't support Tibetan script stacking. This PR addresses that.

  • Add a Tibetan font fallback (local-only, unicode-range: U+0F00-0FFF) so Tibetan text stacks correctly without bundling fonts.
  • Load that fallback once after /theme/current so it wins over the theme’s body font but still respects user custom styles.
  • Preserve each theme’s typography by setting --lute-theme-font-stack to match its existing font stack; To keep each theme’s typography intact (and avoid falling back to the base stack), each theme needed to set --lute-theme-font-stack to match its existing font choices. That way, the new fallback can prepend Tibetan-capable fonts while preserving the look each theme already defined for non-Tibetan text.
  • Include the fallback CSS on all pages (reader, term popup, term sentences, image search) so term-related views get the same Tibetan rendering.

Testing

  • Manual: verified Tibetan text stacks in reader, title, term popup/selector, sentences.
  • Manual: confirmed script-fallbacks.css loads after /theme/current on those pages.
  • Manual negative checks: temporarily broke the Tibetan stack and the theme fallback to ensure the Playwright assertions fail when expected.
  • Automated: created pytest tests/playwright/test_tibetan_font.py (with app running on :5001) passes when fallbacks are correct and fails under the simulated breakages (simulated Tibetan text using not supported font, and simulated non-Tibetan text overriden with Tibetan font instead of theme font)

Before (Characters not stacking properly)
Screenshot 2025-12-06 at 0 13 25
After (Correct character stacking)
Screenshot 2025-12-06 at 0 13 02

jzohrab added 30 commits December 13, 2024 15:22
@jzohrab
Version 3.6.1
f9b86a8
@jzohrab
Extract function for handling data setup/cleanup during start.
9343661
@jzohrab
Move data cleanup to initialization, add progress reporting.
c405900
@jzohrab
Issue 531: term reference search should handle casing correctly.
0dac14d 
This change adds sentence.SeTextLC.  The field is set to '*' if lowercasing the SeText using
the Language.parser returns the same value from sqlite's built-in LOWER function.  This
special character ends up saving many mb of file size in my db, as 99.95% of the sentences
can be downcased with sqlite when searching for references.

Also adds a data cleanup job for users upgrading from prior version.
@jzohrab
Initial term service tests for bulk set parent.
8506330
@jzohrab
Complete bulk parent tests.
dc3b7a3
@jzohrab
Use service for bulk_set_parent.
2df78c2
@jzohrab
Fix lint.
a37d8b6
@jzohrab
Merge branch 'issue_206_dont_throw_if_missing_parent' into develop
275b44f
@jzohrab
Rename templates.
9428fcb
@jzohrab
Add bulk update forms, base form.
24739f1
@jzohrab
Sort tags for test checks.
a2e5b76
@jzohrab
Fix term tag removal.
6843106
@jzohrab
Clean up start_hover_mode().
f4c8394
@jzohrab
Add bulk term processing.
ff51605
@jzohrab
Add acceptance test.
d728dd6
@jzohrab
Support python 3.8 for bulk update struct.
2966e7d
@jzohrab
Extract function.
1448779
@jzohrab
Fix word clicking.
daaf52e
@jzohrab
Bulk term editing save hotkey.
d8b657c
@jzohrab
Fix github ci for coverage.
773d2cb
@jzohrab
Merge branch 'issue_537_bulk_term_actions' into develop
b302d03
@jzohrab
Issue 328: use term filters when table loaded.
b4b5892
@jzohrab
Beta release 3.7.0b1
98719a2
@jzohrab
Click on parent tag should still show dictionaries.
26aeb05
@jzohrab
Beta release 3.7.0b2
db7fba9
@jzohrab
Fix term index bulk form.
c8f271b
@jzohrab
Remove unused const.
c43c78b
@jzohrab
Remove dup postMessage, form already posts that on document.ready.
7afa3d8
@jzohrab
Explicitly hide dictionaries during lute.js methods.
dbf6b62
jzohrab and others added 23 commits February 18, 2025 09:52
@jzohrab
Use SentenceLookup in anki Service.
ed42ad8
@jzohrab
Pass termid sentences map to anki calls.
187c0c5
@jzohrab
Smoke integration test.
2821352
@jzohrab
Merge branch 'iss_579_anki_export_beta_tweaks' into develop
22d63ac
@jzohrab
Beta release 3.10.0b3
6a2cac2
@jzohrab
Add pronunciation to field mappings.
87306c4
@jzohrab
Add parent to anki test only.
ee95c3b
@jzohrab
Don't post on click Cancel for settings.
ede8636
@jzohrab
Beta release 3.10.0b4
ee24e78
@jzohrab
Fix reading pop-up title when copying sentences.
c6ee66d
@jzohrab
Fix button styling.
52b0567
@jzohrab
Add parents.tags field mapping output.
a5ce3a7
@jzohrab
Beta release 3.10.0b5
eda3f6e
@jzohrab
Bump language defs ref.
9692031
@jzohrab
Changelog.
eb559b8
@jzohrab
Version 3.10.0
9d75082
@imamcr
Add AAC, FLAC and WebM support
3b94978
@jzohrab
Merge pull request LuteOrg#589 from imamcr/add_aac_flac_and_webm_support
b831749 
Add AAC, FLAC and WebM support
@jzohrab
Iss 592: Fix html spacing.
30072f7
@jzohrab
Update language defs submodule ref.
542d732
@jzohrab
Issue 594: add parents.pronunciation to anki mapping.
e716872
@jzohrab
Changelog.
d426241
@jzohrab
Version 3.10.1
74af19a
@tomer-gom tomer-gom changed the base branch from master to develop December 5, 2025 18:50
@tomer-gom tomer-gom force-pushed the fix/tibetan_renders_properly branch from 7c962cb to 67dd8c3 Compare December 20, 2025 17:41
@tomer-gom tomer-gom force-pushed the fix/tibetan_renders_properly branch from 67dd8c3 to 6c76810 Compare December 20, 2025 17:54
@tomer-gom tomer-gom closed this Dec 20, 2025
@tomer-gom
Copy link
Author

tomer-gom commented Dec 20, 2025 •
edited
Loading

Opened new pr - #647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tomer-gom @jzohrab @parradam @imamcr